From 909a5af07527861701c40f3a1bc675ad7ca7d2c1 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Mon, 12 Jan 2015 21:57:18 -0500 Subject: [PATCH] Omit post-install warning unless formula defines it Closes Homebrew/homebrew#34744. --- Library/Homebrew/formula.rb | 4 ++++ Library/Homebrew/formula_installer.rb | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb index 727eccdab0..4ecb348e61 100644 --- a/Library/Homebrew/formula.rb +++ b/Library/Homebrew/formula.rb @@ -333,6 +333,10 @@ class Formula # Can be overridden to run commands on both source and bottle installation. def post_install; end + def post_install_defined? + method(:post_install).owner == self.class + end + # tell the user about any caveats regarding this package, return a string def caveats; nil end diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index fb025f0cc7..46a1345ce0 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -383,7 +383,7 @@ class FormulaInstaller link(keg) fix_install_names(keg) if OS.mac? - if build_bottle? + if build_bottle? && formula.post_install_defined? ohai "Not running post_install as we're building a bottle" puts "You can run it manually using `brew postinstall #{formula.name}`" else