From 907a9238c252ef1f0b220e2b469e0a6aa150901c Mon Sep 17 00:00:00 2001 From: Don Chea Date: Wed, 28 Jun 2023 09:11:14 -0400 Subject: [PATCH] Always pass headers as array to downloader, if present We still need to support it being named "header" in the Cask url stanza. --- Library/Homebrew/cask/url.rb | 4 +++- Library/Homebrew/download_strategy.rb | 7 +------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/Library/Homebrew/cask/url.rb b/Library/Homebrew/cask/url.rb index 88f316bda1..dfd0ad23e5 100644 --- a/Library/Homebrew/cask/url.rb +++ b/Library/Homebrew/cask/url.rb @@ -57,6 +57,8 @@ module Cask @uri = URI(uri) + header = Array(header) unless header.nil? + specs = {} specs[:verified] = @verified = verified specs[:using] = @using = using @@ -67,7 +69,7 @@ module Cask specs[:trust_cert] = @trust_cert = trust_cert specs[:cookies] = @cookies = cookies specs[:referer] = @referer = referer - specs[:header] = @header = header + specs[:headers] = @header = header specs[:user_agent] = @user_agent = user_agent || :default specs[:data] = @data = data specs[:only_path] = @only_path = only_path diff --git a/Library/Homebrew/download_strategy.rb b/Library/Homebrew/download_strategy.rb index 2b409eba30..78632ca56a 100644 --- a/Library/Homebrew/download_strategy.rb +++ b/Library/Homebrew/download_strategy.rb @@ -389,12 +389,7 @@ class CurlDownloadStrategy < AbstractFileDownloadStrategy # Merge `:header` with `:headers`. if (header = meta.delete(:header)) meta[:headers] ||= [] - - if header.is_a?(Array) - meta[:headers] += header - else - meta[:headers] << header - end + meta[:headers] << header end super