admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Audit url/devel/head for redundant :using

Browse Source
This commit is contained in:
Adam Vandenberg 2013-05-27 22:24:22 -07:00
parent 0e7d47332c
commit 903c340664
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/cmd/audit.rb
View File

@ -294,6 +294,16 @@ class FormulaAuditor
problem "#{cksum.hash_type} should be lowercase" unless cksum.hexdigest == cksum.hexdigest.downcase problem "#{cksum.hash_type} should be lowercase" unless cksum.hexdigest == cksum.hexdigest.downcase
end end
end end
# Check for :using that is already detected from the url
@specs.each do |s|
next if s.using.nil?
url_strategy = DownloadStrategyDetector.detect(s.url)
using_strategy = DownloadStrategyDetector.detect('', s.using)
problem "redundant :using specification in url or head" if url_strategy == using_strategy
end
end end
def audit_patches def audit_patches

1
Library/Homebrew/formula_support.rb
View File

@ -4,6 +4,7 @@ require 'version'
class SoftwareSpec class SoftwareSpec
attr_reader :checksum, :mirrors, :specs attr_reader :checksum, :mirrors, :specs
attr_reader :using # for auditing
def initialize url=nil, version=nil def initialize url=nil, version=nil
@url = url @url = url