From 8f20ea92b30aa55943c7d0e8ce5ea9bdb6569135 Mon Sep 17 00:00:00 2001 From: Xu Cheng Date: Thu, 6 Aug 2015 16:51:50 +0800 Subject: [PATCH] test_inreplace: temporary disable rubocop string replacement rule --- Library/Homebrew/test/test_inreplace.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/test/test_inreplace.rb b/Library/Homebrew/test/test_inreplace.rb index d9c4c1ab7b..91d57f942f 100644 --- a/Library/Homebrew/test/test_inreplace.rb +++ b/Library/Homebrew/test/test_inreplace.rb @@ -85,7 +85,8 @@ class InreplaceTest < Homebrew::TestCase s.sub!("f", "b") assert_equal "boo", s - s.tr!("o", "e") + # Under current context, we are testing `String#gsub!`, so let's disable rubocop temporarily. + s.gsub!("o", "e") # rubocop:disable Performance/StringReplacement assert_equal "bee", s end @@ -99,7 +100,8 @@ class InreplaceTest < Homebrew::TestCase end assert_raises(Utils::InreplaceError) do - inreplace("test") { |s| s.tr!("d", "f") } + # Under current context, we are testing `String#gsub!`, so let's disable rubocop temporarily. + inreplace("test") { |s| s.gsub!("d", "f") } # rubocop:disable Performance/StringReplacement end assert_raises(Utils::InreplaceError) do