From 8eaa812711ef73597e2287222393b5630dc6a7d8 Mon Sep 17 00:00:00 2001 From: Adam Vandenberg Date: Wed, 22 Sep 2010 08:05:58 -0700 Subject: [PATCH] improve std_cmake_parameters comments --- Library/Homebrew/formula.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb index ebc626a45f..6a382383bc 100644 --- a/Library/Homebrew/formula.rb +++ b/Library/Homebrew/formula.rb @@ -208,12 +208,12 @@ class Formula end end - # we don't have a std_autotools variant because autotools is a lot less - # consistent and the standard parameters are more memorable - # really Homebrew should determine what works inside brew() then - # we could add --disable-dependency-tracking when it will work + # Standard parameters for CMake builds. + # Using Build Type "None" tells cmake to use our CFLAGS,etc. settings. + # Setting it to Release would ignore our flags. + # Note: there isn't a std_autotools variant because autotools is a lot + # less consistent and the standard parameters are more memorable. def std_cmake_parameters - # The None part makes cmake use the environment's CFLAGS etc. settings "-DCMAKE_INSTALL_PREFIX='#{prefix}' -DCMAKE_BUILD_TYPE=None -Wno-dev" end