admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Update based on feedback.

Browse Source
This commit is contained in:
Mike McQuaid 2016-10-13 09:09:40 +01:00 committed by GitHub
parent 114beb77cd
commit 8e3fa21967
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
docs/New-Maintainer-Checklist.md
View File

@ -18,10 +18,12 @@ A few requests:
non-trivial (e.g. not a test or audit improvement or version bump) changes non-trivial (e.g. not a test or audit improvement or version bump) changes
to formulae code and don't merge them unless you get at least one approval to formulae code and don't merge them unless you get at least one approval
and passing tests. and passing tests.
- use `brew pull` for formulae changes that require new bottles and let it - use `brew pull` for formulae changes that require new bottles or change
auto-close issues wherever possible (it may take ~5m). When this isn't necessary multiple formulae and let it auto-close issues wherever possible (it may
use GitHub's "Merge pull request" button. If in doubt, check with GitX that you've not take ~5m). When this isn't necessary use GitHub's "Merge pull request"
accidentally added merge commits button in "create a merge commit" mode for Homebrew/brew or "squash and
merge" for a single formulae change. If in doubt, check with e.g. GitX that
you've not accidentally added merge commits
- still create your branches on your fork rather than in the main repository - still create your branches on your fork rather than in the main repository
- if still in doubt please ask for help and we'll help you out - these are - if still in doubt please ask for help and we'll help you out - these are
probably worth a read: probably worth a read:
@ -37,7 +39,7 @@ Thanks for all your work so far!
If they accept, follow a few steps to get them set up: If they accept, follow a few steps to get them set up:
- [x] Invite them to the [**@Homebrew/maintainers** team](https://github.com/orgs/Homebrew/teams/maintainers) to give them write access to all repositories (but don't make them owners yet). They will need to enable [GitHub's Two Factor Authentication](https://help.github.com/articles/about-two-factor-authentication/). - [x] Invite them to the [**@Homebrew/maintainers** team](https://github.com/orgs/Homebrew/teams/maintainers) to give them write access to all repositories (but don't make them owners yet). They will need to enable [GitHub's Two Factor Authentication](https://help.github.com/articles/about-two-factor-authentication/).
- [x] Ask them to sign in to [Bintray](https://bintray.com) using them GitHub account and they should auto-sync to [Bintray's Homebrew organisation](https://bintray.com/homebrew/organization/edit/members) as a member so they can publish new bottles - [x] Ask them to sign in to [Bintray](https://bintray.com) using their GitHub account and they should auto-sync to [Bintray's Homebrew organisation](https://bintray.com/homebrew/organization/edit/members) as a member so they can publish new bottles
- [x] Add them to the [Jenkins' GitHub Authorization Settings admin user names](https://bot.brew.sh/configureSecurity/) so they can adjust settings and restart jobs - [x] Add them to the [Jenkins' GitHub Authorization Settings admin user names](https://bot.brew.sh/configureSecurity/) so they can adjust settings and restart jobs
- [x] Add them to the [Jenkins' GitHub Pull Request Builder admin list](https://bot.brew.sh/configure) to enable `@BrewTestBot test this please` for them - [x] Add them to the [Jenkins' GitHub Pull Request Builder admin list](https://bot.brew.sh/configure) to enable `@BrewTestBot test this please` for them
- [x] Invite them to the [`homebrew-dev` private maintainers mailing list](https://groups.google.com/forum/#!managemembers/homebrew-dev/invite) - [x] Invite them to the [`homebrew-dev` private maintainers mailing list](https://groups.google.com/forum/#!managemembers/homebrew-dev/invite)