From 8e34b4c322482aada6d27f36c61fd64a139fd78d Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Thu, 5 Feb 2015 11:55:13 +0000 Subject: [PATCH] How-To-Open-a-Homebrew-Pull-Request: bottle update --- .../How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md b/share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md index ed8d3e0216..c2cb240672 100644 --- a/share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md +++ b/share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md @@ -12,7 +12,7 @@ To make a new branch and submit it for review: 1. Checkout the `master` branch with `git checkout master` 2. Retrieve new changes to the `master` branch with `brew update` (which calls `git pull`) 3. Create a new branch from the latest `master` branch with `git checkout -b YOUR_BRANCH_NAME origin/master` -4. Make your changes to any Homebrew formula with `brew edit` (following all the requirements in the [Formula Cookbook](Formula-Cookbook.md)). Run `brew audit ANY_CHANGED_FORMULA`, `brew tests` and `brew install ANY_CHANGED_FORMULA && brew test ANY_CHANGED_FORMULA` and ensure all of these pass without issue. +4. Make your changes to any Homebrew formula with `brew edit` (following all the requirements in the [Formula Cookbook](Formula-Cookbook.md)). Run `brew audit ANY_CHANGED_FORMULA`, `brew tests` and `brew install ANY_CHANGED_FORMULA && brew test ANY_CHANGED_FORMULA` and ensure all of these pass without issue. If there's a `bottle do` block in the formula: don't remove it; we'll update it when we pull it. 5. Make a separate commit for each changed formula with `git add` and `git commit`. 6. Upload your new commits to the branch to your fork with `git push --set-upstream YOUR_USERNAME YOUR_BRANCH_NAME` 7. Go to https://github.com/Homebrew/homebrew and create a pull request to request review and merge of commits in your pushed branch. Make sure you explain why the change is needed and, if fixing a bug, how to reproduce the bug. Await feedback or a merge from Homebrew's maintainers.