admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

search: return results while parsing

Browse Source 
Instead of returning a full list of results after parsing, yield and
print each result as it's found for a snappier user experience.

Closes Homebrew/homebrew#9576.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
This commit is contained in:
Misty De Meo 2012-01-12 21:10:03 -06:00
parent 9a774ac0a6
commit 8d100a0508
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/cmd/search.rb
View File

@ -29,10 +29,8 @@ module Homebrew extend self
end
if search_results.empty? and not blacklisted? query
pulls = GitHub.find_pull_requests rx
unless pulls.empty?
puts "Open pull requests matching \"#{query}\":", *pulls.map { |p| " #{p}" }
end
puts "No formula found for \"#{query}\". Searching open pull requests..."
GitHub.find_pull_requests(rx) { |pull| puts pull }
end
end
end

6
Library/Homebrew/utils.rb
View File

@ -432,17 +432,15 @@ module GitHub extend self
require 'open-uri'
require 'vendor/multi_json'
pulls = []
query = rx.source.delete '.*'
uri = URI.parse("http://github.com/api/v2/json/issues/search/mxcl/homebrew/open/#{query}")
open uri do |f|
MultiJson.decode(f.read)["issues"].each do |pull|
pulls << pull['pull_request_url'] if rx.match pull['title'] and pull["pull_request_url"]
yield pull['pull_request_url'] if rx.match pull['title'] and pull["pull_request_url"]
end
end
pulls
rescue
[]
nil
end
end