Cleanup brew-pull code.

Library/Contributions/cmds/brew-pull.rb

@@ -1,57 +1,56 @@
 # Gets a patch from a GitHub commit or pull request and applies it to Homebrew.
 # Optionally, installs it too.
 
-require 'utils.rb'
-
-if ARGV.include? '--install'
-  ARGV.delete '--install'
-  install = true
-end
+require 'utils'
 
 if ARGV.empty?
   onoe 'This command requires at least one argument containing a URL or pull request number'
 end
 
-HOMEBREW_REPOSITORY.cd do
-  ARGV.named.each do|arg|
+Dir.chdir HOMEBREW_REPOSITORY
+
+ARGV.named.each do|arg|
   if arg.to_i > 0
-      url = 'https://github.com/mxcl/homebrew/pull/' + arg + '.patch'
+    url = 'https://github.com/mxcl/homebrew/pull/' + arg
   else
     # This regex should work, if it's too precise, feel free to fix it.
-      urlmatch = arg.match 'https:\/\/github.com\/\w+\/homebrew\/(pull\/(\d+)|commit\/\w{4,40})'
-      if !urlmatch
+    url_match = arg.match 'https:\/\/github.com\/\w+\/homebrew\/(pull\/(\d+)|commit\/\w{4,40})'
+    unless url_match
       ohai 'Ignoring URL:', "Not a GitHub pull request or commit: #{arg}"
       next
     end
 
-      # GitHub provides commits'/pull-requests' raw patches using this URL.
-      url = urlmatch[0] + '.patch'
+    url = url_match[0]
   end
 
+  # GitHub provides commits'/pull-requests' raw patches using this URL.
+  url += '.patch'
+
   # The cache directory seems like a good place to put patches.
   HOMEBREW_CACHE.mkpath
-    patchpath = (HOMEBREW_CACHE+File.basename(url))
+  patchpath = HOMEBREW_CACHE + File.basename(url)
   curl url, '-o', patchpath
 
   # Store current revision
-    revision = `git log -n1 --format=%H`.strip()
+  revision = `git rev-parse --short HEAD`.strip
 
   ohai 'Applying patch'
-    patch_args = %w[am --signoff]
+  patch_args = ['am']
+  patch_args << '--signoff' unless ARGV.include? '--clean'
   # Normally we don't want whitespace errors, but squashing them can break
   # patches so an option is provided to skip this step.
-    patch_args << '--whitespace=fix' unless ARGV.include? '--ignore-whitespace'
+  patch_args << '--whitespace=fix' unless ARGV.include? '--ignore-whitespace' or ARGV.include? '--clean'
   patch_args << patchpath
 
   safe_system 'git', *patch_args
 
-    issue = arg.to_i > 0 ? arg.to_i : urlmatch[2]
-    if issue
+  issue = arg.to_i > 0 ? arg.to_i : url_match[2]
+  if issue and not ARGV.include? '--clean'
     ohai "Patch closes issue ##{issue}"
     message = `git log HEAD^.. --format=%B`
 
     # If this is a pull request, append a close message.
-      if !message.include? 'Closes #'
+    unless message.include? 'Closes #'
       issueline = "Closes ##{issue}."
       signed = 'Signed-off-by:'
       message = message.gsub signed, issueline + "\n\n" + signed
@@ -62,9 +61,9 @@ HOMEBREW_REPOSITORY.cd do
   ohai 'Patch changed:'
   safe_system 'git', 'diff', "#{revision}..", '--stat'
 
-    if install
+  if ARGV.include? '--install'
     `git diff #{revision}.. --name-status`.each_line do |line|
-        status, filename = line.split()
+      status, filename = line.split
       # Don't try and do anything to removed files.
       if (status == 'A' or status == 'M') and filename.include? '/Formula/'
         formula = File.basename(filename, '.rb')
@@ -74,5 +73,4 @@ HOMEBREW_REPOSITORY.cd do
       end
     end
   end
-  end
 end