Cleanup brew-pull code.

Library/Contributions/cmds/brew-pull.rb

@@ -1,77 +1,75 @@
 # Gets a patch from a GitHub commit or pull request and applies it to Homebrew.
 # Optionally, installs it too.
 
-require 'utils.rb'
+require 'utils'
-
-if ARGV.include? '--install'
-  ARGV.delete '--install'
-  install = true
-end
 
 if ARGV.empty?
   onoe 'This command requires at least one argument containing a URL or pull request number'
 end
 
-HOMEBREW_REPOSITORY.cd do
+Dir.chdir HOMEBREW_REPOSITORY
-  ARGV.named.each do|arg|
-    if arg.to_i > 0
-      url = 'https://github.com/mxcl/homebrew/pull/' + arg + '.patch'
-    else
-      # This regex should work, if it's too precise, feel free to fix it.
-      urlmatch = arg.match 'https:\/\/github.com\/\w+\/homebrew\/(pull\/(\d+)|commit\/\w{4,40})'
-      if !urlmatch
-        ohai 'Ignoring URL:', "Not a GitHub pull request or commit: #{arg}"
-        next
-      end
 
-      # GitHub provides commits'/pull-requests' raw patches using this URL.
+ARGV.named.each do|arg|
-      url = urlmatch[0] + '.patch'
+  if arg.to_i > 0
+    url = 'https://github.com/mxcl/homebrew/pull/' + arg
+  else
+    # This regex should work, if it's too precise, feel free to fix it.
+    url_match = arg.match 'https:\/\/github.com\/\w+\/homebrew\/(pull\/(\d+)|commit\/\w{4,40})'
+    unless url_match
+      ohai 'Ignoring URL:', "Not a GitHub pull request or commit: #{arg}"
+      next
     end
 
-    # The cache directory seems like a good place to put patches.
+    url = url_match[0]
-    HOMEBREW_CACHE.mkpath
+  end
-    patchpath = (HOMEBREW_CACHE+File.basename(url))
-    curl url, '-o', patchpath
 
-    # Store current revision
+  # GitHub provides commits'/pull-requests' raw patches using this URL.
-    revision = `git log -n1 --format=%H`.strip()
+  url += '.patch'
 
-    ohai 'Applying patch'
+  # The cache directory seems like a good place to put patches.
-    patch_args = %w[am --signoff]
+  HOMEBREW_CACHE.mkpath
-    # Normally we don't want whitespace errors, but squashing them can break
+  patchpath = HOMEBREW_CACHE + File.basename(url)
-    # patches so an option is provided to skip this step.
+  curl url, '-o', patchpath
-    patch_args << '--whitespace=fix' unless ARGV.include? '--ignore-whitespace'
-    patch_args << patchpath
 
-    safe_system 'git', *patch_args
+  # Store current revision
+  revision = `git rev-parse --short HEAD`.strip
 
-    issue = arg.to_i > 0 ? arg.to_i : urlmatch[2]
+  ohai 'Applying patch'
-    if issue
+  patch_args = ['am']
-      ohai "Patch closes issue ##{issue}"
+  patch_args << '--signoff' unless ARGV.include? '--clean'
-      message = `git log HEAD^.. --format=%B`
+  # Normally we don't want whitespace errors, but squashing them can break
+  # patches so an option is provided to skip this step.
+  patch_args << '--whitespace=fix' unless ARGV.include? '--ignore-whitespace' or ARGV.include? '--clean'
+  patch_args << patchpath
 
-      # If this is a pull request, append a close message.
+  safe_system 'git', *patch_args
-      if !message.include? 'Closes #'
+
-        issueline = "Closes ##{issue}."
+  issue = arg.to_i > 0 ? arg.to_i : url_match[2]
-        signed = 'Signed-off-by:'
+  if issue and not ARGV.include? '--clean'
-        message = message.gsub signed, issueline + "\n\n" + signed
+    ohai "Patch closes issue ##{issue}"
-        safe_system 'git', 'commit', '--amend', '-q', '-m', message
+    message = `git log HEAD^.. --format=%B`
-      end
+
+    # If this is a pull request, append a close message.
+    unless message.include? 'Closes #'
+      issueline = "Closes ##{issue}."
+      signed = 'Signed-off-by:'
+      message = message.gsub signed, issueline + "\n\n" + signed
+      safe_system 'git', 'commit', '--amend', '-q', '-m', message
     end
+  end
 
-    ohai 'Patch changed:'
+  ohai 'Patch changed:'
-    safe_system 'git', 'diff', "#{revision}..", '--stat'
+  safe_system 'git', 'diff', "#{revision}..", '--stat'
 
-    if install
+  if ARGV.include? '--install'
-      `git diff #{revision}.. --name-status`.each_line do |line|
+    `git diff #{revision}.. --name-status`.each_line do |line|
-        status, filename = line.split()
+      status, filename = line.split
-        # Don't try and do anything to removed files.
+      # Don't try and do anything to removed files.
-        if (status == 'A' or status == 'M') and filename.include? '/Formula/'
+      if (status == 'A' or status == 'M') and filename.include? '/Formula/'
-          formula = File.basename(filename, '.rb')
+        formula = File.basename(filename, '.rb')
-          ohai "Installing #{formula}"
+        ohai "Installing #{formula}"
-          # Not sure if this is the best way to install?
+        # Not sure if this is the best way to install?
-          safe_system 'brew', 'install', '--force', '--build-bottle', formula
+        safe_system 'brew', 'install', '--force', '--build-bottle', formula
-        end
       end
     end
   end