admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #3086 from MikeMcQuaid/audit-taps-shush

Browse Source 
audit: don't output when searching taps.
This commit is contained in:
Mike McQuaid 2017-08-24 11:17:31 +01:00 committed by GitHub
commit 8b7defb3eb
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/cmd/search.rb
View File

@ -102,11 +102,13 @@ module Homebrew
odie "#{query} is not a valid regex" odie "#{query} is not a valid regex"
end end
def search_taps(query) def search_taps(query, silent: false)
return [] if ENV["HOMEBREW_NO_GITHUB_API"] return [] if ENV["HOMEBREW_NO_GITHUB_API"]
# Use stderr to avoid breaking parsed output # Use stderr to avoid breaking parsed output
$stderr.puts Formatter.headline("Searching taps on GitHub...", color: :blue) unless silent
$stderr.puts Formatter.headline("Searching taps on GitHub...", color: :blue)
end
valid_dirnames = ["Formula", "HomebrewFormula", "Casks", "."].freeze valid_dirnames = ["Formula", "HomebrewFormula", "Casks", "."].freeze
matches = GitHub.search_code(user: ["Homebrew", "caskroom"], filename: query, extension: "rb") matches = GitHub.search_code(user: ["Homebrew", "caskroom"], filename: query, extension: "rb")

2
Library/Homebrew/dev-cmd/audit.rb
View File

@ -412,7 +412,7 @@ class FormulaAuditor
same_name_tap_formulae = @@local_official_taps_name_map[name] || [] same_name_tap_formulae = @@local_official_taps_name_map[name] || []
if @online if @online
Homebrew.search_taps(name).each do |tap_formula_full_name| Homebrew.search_taps(name, silent: true).each do |tap_formula_full_name|
tap_formula_name = tap_formula_full_name.split("/").last tap_formula_name = tap_formula_full_name.split("/").last
next if tap_formula_name != name next if tap_formula_name != name
same_name_tap_formulae << tap_formula_full_name same_name_tap_formulae << tap_formula_full_name