From a94037a6ff69c8665890f8c8d271f6252a576de1 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 21 May 2025 13:08:37 +0100 Subject: [PATCH 1/2] dev-cmd/update-maintainers: various fixes. - install the `man` gem group for `kramdown` so `Manpages.regenerate_man_pages` can run successfully - hardcode the non-organisation PLC members so that they aren't missing from the GitHub team - correctly populate the PLC members again --- Library/Homebrew/dev-cmd/update-maintainers.rb | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/dev-cmd/update-maintainers.rb b/Library/Homebrew/dev-cmd/update-maintainers.rb index 0b5dd62980..57f52e9713 100644 --- a/Library/Homebrew/dev-cmd/update-maintainers.rb +++ b/Library/Homebrew/dev-cmd/update-maintainers.rb @@ -21,12 +21,22 @@ module Homebrew sig { override.void } def run + # Needed for Manpages.regenerate_man_pages below + Homebrew.install_bundler_gems!(groups: ["man"]) + # We assume that only public members wish to be included in the README public_members = GitHub.public_member_usernames("Homebrew") maintainers = GitHub.members_by_team("Homebrew", "maintainers") + # Not all PLC members are Homebrew GitHub organisation members any more + non_maintainer_plc_members = { + colindean: "Colin Dean", + mozzadrella: "Vanessa Gennarelli", + }.transform_keys(&:to_s) + public_members += non_maintainer_plc_members.keys + members = { - plc: GitHub.members_by_team("Homebrew", "plc"), + plc: GitHub.members_by_team("Homebrew", "plc").merge(non_maintainer_plc_members), tsc: GitHub.members_by_team("Homebrew", "tsc"), maintainers:, } From ee15435a905835a618992445f2170467f524222f Mon Sep 17 00:00:00 2001 From: Issy Long Date: Wed, 21 May 2025 14:31:58 +0200 Subject: [PATCH 2/2] Fix multiline hash key/value indentation --- Library/Homebrew/dev-cmd/update-maintainers.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/dev-cmd/update-maintainers.rb b/Library/Homebrew/dev-cmd/update-maintainers.rb index 57f52e9713..e1ca6a550f 100644 --- a/Library/Homebrew/dev-cmd/update-maintainers.rb +++ b/Library/Homebrew/dev-cmd/update-maintainers.rb @@ -30,7 +30,7 @@ module Homebrew # Not all PLC members are Homebrew GitHub organisation members any more non_maintainer_plc_members = { - colindean: "Colin Dean", + colindean: "Colin Dean", mozzadrella: "Vanessa Gennarelli", }.transform_keys(&:to_s) public_members += non_maintainer_plc_members.keys