From 04e07dc0db368bab3c88905179b725dc7a4d44e6 Mon Sep 17 00:00:00 2001
From: Mike McQuaid <mike@mikemcquaid.com>
Date: Tue, 1 Aug 2023 12:00:30 +0100
Subject: [PATCH] Deprecate `postgresql-upgrade-database`

This is an out-of-band deprecation but this command is broken and we're
not going to fix it so it's not really worth a deprecation cycle.

See https://github.com/orgs/Homebrew/discussions/4685
---
 Library/Homebrew/cmd/postgresql-upgrade-database.rb | 5 +++++
 docs/Manpage.md                                     | 4 ----
 manpages/brew.1                                     | 3 ---
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/Library/Homebrew/cmd/postgresql-upgrade-database.rb b/Library/Homebrew/cmd/postgresql-upgrade-database.rb
index eae11e79a3..0a6fe5ae68 100755
--- a/Library/Homebrew/cmd/postgresql-upgrade-database.rb
+++ b/Library/Homebrew/cmd/postgresql-upgrade-database.rb
@@ -15,6 +15,8 @@ module Homebrew
       EOS
 
       named_args :none
+
+      hide_from_man_page!
     end
   end
 
@@ -22,6 +24,9 @@ module Homebrew
   def postgresql_upgrade_database
     postgresql_upgrade_database_args.parse
 
+    odeprecated "brew postgresql_upgrade_database",
+                "using new, versioned e.g. `var/postgres@14` datadir and `pg_upgrade`"
+
     name = "postgresql"
     pg = Formula[name]
     bin = pg.bin
diff --git a/docs/Manpage.md b/docs/Manpage.md
index 7b8cb102a3..b99c8964c0 100644
--- a/docs/Manpage.md
+++ b/docs/Manpage.md
@@ -529,10 +529,6 @@ information is displayed in interactive shells, and suppressed otherwise.
 Pin the specified *`formula`*, preventing them from being upgraded when
 issuing the `brew upgrade` *`formula`* command. See also `unpin`.
 
-### `postgresql-upgrade-database`
-
-Upgrades the database for the `postgresql` formula.
-
 ### `postinstall`, `post_install` *`installed_formula`* [...]
 
 Rerun the post-install steps for *`formula`*.
diff --git a/manpages/brew.1 b/manpages/brew.1
index 9225cd3697..90b6c8e9ef 100644
--- a/manpages/brew.1
+++ b/manpages/brew.1
@@ -743,9 +743,6 @@ Also include outdated casks including those with \fBauto_updates true\fR\.
 .SS "\fBpin\fR \fIinstalled_formula\fR [\.\.\.]"
 Pin the specified \fIformula\fR, preventing them from being upgraded when issuing the \fBbrew upgrade\fR \fIformula\fR command\. See also \fBunpin\fR\.
 .
-.SS "\fBpostgresql\-upgrade\-database\fR"
-Upgrades the database for the \fBpostgresql\fR formula\.
-.
 .SS "\fBpostinstall\fR, \fBpost_install\fR \fIinstalled_formula\fR [\.\.\.]"
 Rerun the post\-install steps for \fIformula\fR\.
 .