admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: Raise a problem if the SourceForge download url uses http instead of https

Browse Source 
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
This commit is contained in:
Jaime Marquínez Ferrándiz 2014-02-26 21:51:46 +01:00 committed by Adam Vandenberg
parent c534b1907d
commit 8a014b3221
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/cmd/audit.rb
View File

@ -223,7 +223,7 @@ class FormulaAuditor
next if p =~ %r[svn\.sourceforge] next if p =~ %r[svn\.sourceforge]
# Is it a sourceforge http(s) URL? # Is it a sourceforge http(s) URL?
next unless p =~ %r[^https?://.*\bsourceforge\.com] next unless p =~ %r[^https?://.*\b(sourceforge|sf)\.(com|net)]
if p =~ /(\?|&)use_mirror=/ if p =~ /(\?|&)use_mirror=/
problem "Don't use #{$1}use_mirror in SourceForge urls (url is #{p})." problem "Don't use #{$1}use_mirror in SourceForge urls (url is #{p})."
@ -245,6 +245,10 @@ class FormulaAuditor
if p =~ %r[^http://\w+\.dl\.] if p =~ %r[^http://\w+\.dl\.]
problem "Don't use specific dl mirrors in SourceForge urls (url is #{p})." problem "Don't use specific dl mirrors in SourceForge urls (url is #{p})."
end end
if p.start_with? "http://downloads"
problem "Use https:// URLs for downloads from SourceForge (url is #{p})."
end
end end
# Check for git:// GitHub repo urls, https:// is preferred. # Check for git:// GitHub repo urls, https:// is preferred.