admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #10183 from carlocab/clt-bottles

Browse Source 
formula_installer: improve no-bottle error message
This commit is contained in:
Mike McQuaid 2020-12-31 15:34:21 +00:00 committed by GitHub
commit 881cd6a5c4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/formula_installer.rb
View File

@ -242,8 +242,13 @@ class FormulaInstaller
# Integration tests override homebrew-core locations # Integration tests override homebrew-core locations
ENV["HOMEBREW_TEST_TMPDIR"].nil? && ENV["HOMEBREW_TEST_TMPDIR"].nil? &&
!pour_bottle? !pour_bottle?
raise CannotInstallFormulaError, <<~EOS message = <<~EOS
#{formula}: no bottle available! #{formula}: no bottle available!
EOS
if !formula.pour_bottle? && formula.pour_bottle_check_unsatisfied_reason
message += formula.pour_bottle_check_unsatisfied_reason
end
message += <<~EOS
You can try to install from source with e.g. You can try to install from source with e.g.
brew install --build-from-source #{formula} brew install --build-from-source #{formula}
Please note building from source is unsupported. You will encounter build Please note building from source is unsupported. You will encounter build
@ -251,6 +256,7 @@ class FormulaInstaller
requests instead of asking for help on Homebrew's GitHub, Twitter or any other requests instead of asking for help on Homebrew's GitHub, Twitter or any other
official channels. official channels.
EOS EOS
raise CannotInstallFormulaError, message
end end
type, reason = DeprecateDisable.deprecate_disable_info formula type, reason = DeprecateDisable.deprecate_disable_info formula