From 8806178cf33efb059c664f6f0f22086526f92ddd Mon Sep 17 00:00:00 2001 From: Sean Molenaar Date: Tue, 21 Feb 2023 17:02:01 +0100 Subject: [PATCH] cask: audit if sparkle livecheck needs multipart version --- Library/Homebrew/cask/audit.rb | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Library/Homebrew/cask/audit.rb b/Library/Homebrew/cask/audit.rb index 20bb834248..84c8e613c9 100644 --- a/Library/Homebrew/cask/audit.rb +++ b/Library/Homebrew/cask/audit.rb @@ -474,6 +474,16 @@ module Cask add_error "download not possible: #{e}" end + sig { void } + def audit_appcast_unneeded_long_version + return unless cask.livecheck.strategy == :sparkle + return unless cask.version.csv.second + return if cask.url.to_s.include? cask.version.csv.second + return if cask.url.to_s.include? cask.version.csv.third + + add_warning "Download does not require additional version components. Use `&:short_version` in the livecheck" + end + sig { void } def audit_signing return if !signing? || download.blank? || cask.url.blank?