From 87540ada6af176481f16f2388d32d8d88f136d76 Mon Sep 17 00:00:00 2001 From: Martin Afanasjew Date: Mon, 25 Jul 2016 13:36:04 +0200 Subject: [PATCH] utils/github: fix reverted order of credentials We always return the token/password first and, if applicable, the user name is the second element in the returned array. Closes #581. Signed-off-by: Martin Afanasjew --- Library/Homebrew/utils/github.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/utils/github.rb b/Library/Homebrew/utils/github.rb index 7f0b945678..c7e43ec076 100644 --- a/Library/Homebrew/utils/github.rb +++ b/Library/Homebrew/utils/github.rb @@ -50,7 +50,7 @@ module GitHub if ENV["HOMEBREW_GITHUB_API_TOKEN"] ENV["HOMEBREW_GITHUB_API_TOKEN"] elsif ENV["HOMEBREW_GITHUB_API_USERNAME"] && ENV["HOMEBREW_GITHUB_API_PASSWORD"] - [ENV["HOMEBREW_GITHUB_API_USERNAME"], ENV["HOMEBREW_GITHUB_API_PASSWORD"]] + [ENV["HOMEBREW_GITHUB_API_PASSWORD"], ENV["HOMEBREW_GITHUB_API_USERNAME"]] else github_credentials = api_credentials_from_keychain github_username = github_credentials[/username=(.+)/, 1]