audit: enforce new https url style for gnome downloads

also delete extra closing parenthesis in two problem messages

Closes Homebrew/homebrew#38824.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
This commit is contained in:
Viktor Szakats 2015-04-19 15:14:11 +02:00 committed by Mike McQuaid
parent 64e07fc990
commit 86ee198af9

View File

@ -279,9 +279,9 @@ class FormulaAuditor
# "Software" is redirected to https://wiki.freedesktop.org/www/Software/project_name # "Software" is redirected to https://wiki.freedesktop.org/www/Software/project_name
if homepage =~ %r[^http://((?:www|nice|libopenraw|liboil|telepathy|xorg)\.)?freedesktop\.org/(?:wiki/)?] if homepage =~ %r[^http://((?:www|nice|libopenraw|liboil|telepathy|xorg)\.)?freedesktop\.org/(?:wiki/)?]
if homepage =~ /Software/ if homepage =~ /Software/
problem "The url should be styled `https://wiki.freedesktop.org/www/Software/project_name`, not #{homepage})." problem "The url should be styled `https://wiki.freedesktop.org/www/Software/project_name`, not #{homepage}."
else else
problem "The url should be styled `https://wiki.freedesktop.org/project_name`, not #{homepage})." problem "The url should be styled `https://wiki.freedesktop.org/project_name`, not #{homepage}."
end end
end end
@ -342,6 +342,8 @@ class FormulaAuditor
problem "Bintray urls should be https://, not http (url is #{p})." problem "Bintray urls should be https://, not http (url is #{p})."
when %r[^http://tools\.ietf\.org/] when %r[^http://tools\.ietf\.org/]
problem "ietf urls should be https://, not http (url is #{p})." problem "ietf urls should be https://, not http (url is #{p})."
when %r[^(http|ftp)://ftp\.gnome\.org/pub/gnome/(.*)]i
problem "Gnome url should be `https://download.gnome.org/#{$2}` (url is #{p})."
end end
end end