admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

More linewise audits

Browse Source
This commit is contained in:
Jack Nagel 2013-07-16 21:39:46 -05:00
parent b4bb0bf1c0
commit 86cf6f0329
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Library/Homebrew/cmd/audit.rb
View File

@ -337,21 +337,21 @@ class FormulaAuditor
end
# Commented-out cmake support from default template
if (text =~ /# system "cmake/)
if line =~ /# system "cmake/
problem "Commented cmake call found"
end
# Comments from default template
if (text =~ /# PLEASE REMOVE/)
if line =~ /# PLEASE REMOVE/
problem "Please remove default template comments"
end
if (text =~ /# if this fails, try separate make\/make install steps/)
if line =~ /# if this fails, try separate make\/make install steps/
problem "Please remove default template comments"
end
if (text =~ /# if your formula requires any X11\/XQuartz components/)
if line =~ /# if your formula requires any X11\/XQuartz components/
problem "Please remove default template comments"
end
if (text =~ /# if your formula's build system can't parallelize/)
if line =~ /# if your formula's build system can't parallelize/
problem "Please remove default template comments"
end
@ -424,7 +424,7 @@ class FormulaAuditor
end
# xcodebuild should specify SYMROOT
if line =~ /system\s+['"]xcodebuild/ and not text =~ /SYMROOT=/
if line =~ /system\s+['"]xcodebuild/ and not line =~ /SYMROOT=/
problem "xcodebuild should be passed an explicit \"SYMROOT\""
end