admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #15983 from razvanazamfirei/deprecate-online-flag

Browse Source 
bump-cask-pr: deprecate online flag
This commit is contained in:
Mike McQuaid 2023-09-11 14:27:01 +01:00 committed by GitHub
commit 86acd120b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Library/Homebrew/dev-cmd/bump-cask-pr.rb
View File

@ -30,7 +30,7 @@ module Homebrew
switch "--no-audit",
description: "Don't run `brew audit` before opening the PR."
switch "--online",
description: "Run `brew audit --online` before opening the PR."
hidden: true
switch "--no-style",
description: "Don't run `brew style --fix` before opening the PR."
switch "--no-browse",
@ -67,6 +67,7 @@ module Homebrew
def bump_cask_pr
args = bump_cask_pr_args.parse
# odeprecated "brew bump-cask-pr --online" if args.online?
# This will be run by `brew audit` or `brew style` later so run it first to
# not start spamming during normal output.
Homebrew.install_bundler_gems! if !args.no_audit? || !args.no_style?
@ -268,21 +269,16 @@ module Homebrew
if args.dry_run?
if args.no_audit?
ohai "Skipping `brew audit`"
elsif args.online?
ohai "brew audit --cask --online #{cask.full_name}"
else
ohai "brew audit --cask #{cask.full_name}"
ohai "brew audit --cask --online #{cask.full_name}"
end
return
end
failed_audit = false
if args.no_audit?
ohai "Skipping `brew audit`"
elsif args.online?
system HOMEBREW_BREW_FILE, "audit", "--cask", "--online", cask.full_name
failed_audit = !$CHILD_STATUS.success?
else
system HOMEBREW_BREW_FILE, "audit", "--cask", cask.full_name
system HOMEBREW_BREW_FILE, "audit", "--cask", "--online", cask.full_name
failed_audit = !$CHILD_STATUS.success?
end
return unless failed_audit