Merge pull request #13989 from issyl0/sorbet-rbi-is-in-maintenance

Library/Homebrew/Gemfile

@@ -34,6 +34,7 @@ gem "warning", require: false
 group :sorbet, optional: true do
   gem "parlour", require: false
   gem "sorbet-static-and-runtime", require: false
+  gem "spoom", require: false
   gem "tapioca", require: false
 end
 

Library/Homebrew/Gemfile.lock

@@ -236,6 +236,7 @@ DEPENDENCIES
   simplecov-cobertura
   sorbet-runtime
   sorbet-static-and-runtime
+  spoom
   tapioca
   warning
 

Library/Homebrew/cask/artifact/mdimporter.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

Library/Homebrew/cask/artifact/moved.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "cask/artifact/relocated"

Library/Homebrew/cask/artifact/pkg.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "plist"

Library/Homebrew/cask/artifact/qlplugin.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

Library/Homebrew/cask/artifact/symlinked.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "cask/artifact/relocated"

Library/Homebrew/caveats.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "language/python"

Library/Homebrew/dev-cmd/generate-man-completions.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "formula"

Library/Homebrew/dev-cmd/typecheck.rb

@@ -68,38 +68,11 @@ module Homebrew
         safe_system "bundle", "exec", "tapioca", "gem", *tapioca_args
         safe_system "bundle", "exec", "parlour"
         safe_system "bundle", "exec", "srb", "rbi", "hidden-definitions"
-        safe_system "bundle", "exec", "srb", "rbi", "todo"
+        safe_system "bundle", "exec", "tapioca", "todo"
 
         if args.suggest_typed?
-          result = system_command(
+          ohai "Bumping Sorbet `typed` sigils..."
-            "bundle",
+          safe_system "bundle", "exec", "spoom", "bump"
-            args:         ["exec", "--", "srb", "tc", "--suggest-typed", "--typed=strict",
-                           "--isolate-error-code=7022"],
-            print_stderr: false,
-          )
-
-          allowed_changes = {
-            "false" => ["true", "strict"],
-            "true"  => ["strict"],
-          }
-
-          # Workaround for `srb tc rbi suggest-typed`, which currently fails get to a converging state.
-          result.stderr.scan(/^(.*\.rb):\d+:\s+You could add `#\s*typed:\s*(.*?)`/).each do |path, new_level|
-            path = Pathname(path)
-
-            next unless path.file?
-
-            contents = path.read
-
-            next unless (match = contents.match(/\A\s*#\s*typed:\s*([^\s]+)/))
-
-            existing_level = match[1]
-
-            next unless allowed_changes.fetch(existing_level, []).include?(new_level)
-
-            puts "#{path}: #{existing_level} -> #{new_level}"
-            path.atomic_write contents.sub(/\A(\s*#\s*typed:\s*)(?:[^\s]+)/, "\\1#{new_level}")
-          end
         end
 
         return

Library/Homebrew/dev-cmd/update-maintainers.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "cli/parser"

Library/Homebrew/extend/os/args.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "extend/os/linux/args" if OS.linux?

Library/Homebrew/extend/os/linux/args.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 module Homebrew

Library/Homebrew/extend/os/linux/parser.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 module Homebrew

Library/Homebrew/extend/os/parser.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "extend/os/linux/parser" if OS.linux?

Library/Homebrew/linuxbrew-core-migration.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 # List of formulae that had a revision in linuxbrew-core

Library/Homebrew/livecheck/strategy/git.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "open3"

Library/Homebrew/rubocops/cask/variables.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "forwardable"

Library/Homebrew/sorbet/rbi/todo.rbi

@@ -1,7 +1,9 @@
-# This file is autogenerated. Do not edit it by hand. Regenerate it with:
+# DO NOT EDIT MANUALLY
-#   srb rbi todo
+# This is an autogenerated file for unresolved constants.
+# Please instead update this file by running `bin/tapioca todo`.
+
+# typed: false
 
-# typed: strong
 module ::StackProf; end
 module T::InterfaceWrapper::Helpers; end
 module T::Private::Abstract::Hooks; end

Library/Homebrew/unpack_strategy/uncompressed.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 module UnpackStrategy

Library/Homebrew/utils/fork.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "fcntl"

Library/Homebrew/utils/rubocop.rb

@@ -1,5 +1,5 @@
 #!/usr/bin/env ruby
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require_relative "../standalone"

Library/Homebrew/yard/ignore_directives.rb

@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 # from https://github.com/lsegal/yard/issues/484#issuecomment-442586899