Merge pull request #14704 from dduugg/rubocop-cleanup

Remove redundant rubocop configs

Library/.rubocop.yml

@@ -76,10 +76,6 @@ Layout/SpaceBeforeBrackets:
     - "/**/{Formula,Casks}/*.rb"
     - "**/{Formula,Casks}/*.rb"
 
-# Use `<<~` for heredocs.
-Layout/HeredocIndentation:
-  Enabled: true
-
 # Keyword arguments don't have the same readability
 # problems as normal parameters.
 Metrics/ParameterLists:
@@ -117,7 +113,6 @@ Naming/VariableNumber:
 
 # Require &&/|| instead of and/or
 Style/AndOr:
-  Enabled: true
   EnforcedStyle: always
 
 # Avoid leaking resources.
@@ -145,14 +140,6 @@ Style/FetchEnvVar:
 Style/FormatStringToken:
   EnforcedStyle: annotated
 
-# autocorrectable and more readable
-Style/HashEachMethods:
-  Enabled: true
-Style/HashTransformKeys:
-  Enabled: true
-Style/HashTransformValues:
-  Enabled: true
-
 # Allow for license expressions
 Style/HashAsLastArrayItem:
   Exclude:
@@ -160,10 +147,6 @@ Style/HashAsLastArrayItem:
     - "/**/Formula/*.rb"
     - "**/Formula/*.rb"
 
-# Enabled now LineLength is lowish.
-Style/IfUnlessModifier:
-  Enabled: true
-
 # Only use this for numbers >= `1_000_000`.
 Style/NumericLiterals:
   MinDigits: 7
@@ -297,10 +280,6 @@ Layout/EndAlignment:
 Layout/SpaceAroundOperators:
   Enabled: false
 
-# layout is not configurable (https://github.com/rubocop-hq/rubocop/issues/6254).
-Layout/RescueEnsureAlignment:
-  Enabled: false
-
 # significantly less indentation involved; more consistent
 Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
@@ -452,11 +431,6 @@ Sorbet/StrictSigil:
 Sorbet/ConstantsFromStrings:
   Enabled: false
 
-# Avoid false positives on modifiers used on symbols of methods
-# See https://github.com/rubocop-hq/rubocop/issues/5953
-Style/AccessModifierDeclarations:
-  Enabled: false
-
 # Conflicts with type signatures on `attr_*`s.
 Style/AccessorGrouping:
   Enabled: false
@@ -507,10 +481,6 @@ Style/GuardClause:
     - "/**/{Formula,Casks}/*.rb"
     - "**/{Formula,Casks}/*.rb"
 
-# avoid hash rockets where possible
-Style/HashSyntax:
-  EnforcedStyle: ruby19
-
 # OpenStruct is a nice helper.
 Style/OpenStructUse:
   Enabled: false