admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Popen spec: ensure Rubocop is happy

Browse Source 
These were introduced in #10305 but only started going red
after that PR was merged.
This commit is contained in:
Misty De Meo 2021-01-13 11:21:10 -08:00
parent c197e9a27d
commit 847897fdac
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/test/utils/popen_spec.rb
View File

@ -75,12 +75,12 @@ describe Utils do
describe "::safe_popen_read" do describe "::safe_popen_read" do
it "does not raise an error if the command succeeds" do it "does not raise an error if the command succeeds" do
expect(subject.safe_popen_read("sh", "-c", "true")).to eq("") expect(described_class.safe_popen_read("sh", "-c", "true")).to eq("")
expect($CHILD_STATUS).to be_a_success expect($CHILD_STATUS).to be_a_success
end end
it "raises an error if the command fails" do it "raises an error if the command fails" do
expect { subject.safe_popen_read("sh", "-c", "false") }.to raise_error(ErrorDuringExecution) expect { described_class.safe_popen_read("sh", "-c", "false") }.to raise_error(ErrorDuringExecution)
expect($CHILD_STATUS).to be_a_failure expect($CHILD_STATUS).to be_a_failure
end end
end end
@ -88,14 +88,14 @@ describe Utils do
describe "::safe_popen_write" do describe "::safe_popen_write" do
it "does not raise an error if the command succeeds" do it "does not raise an error if the command succeeds" do
expect( expect(
subject.safe_popen_write("grep", "success") { |pipe| pipe.write "success\n" }.chomp, described_class.safe_popen_write("grep", "success") { |pipe| pipe.write "success\n" }.chomp,
).to eq("success") ).to eq("success")
expect($CHILD_STATUS).to be_a_success expect($CHILD_STATUS).to be_a_success
end end
it "raises an error if the command fails" do it "raises an error if the command fails" do
expect { expect {
subject.safe_popen_write("grep", "success") { |pipe| pipe.write "failure\n" } described_class.safe_popen_write("grep", "success") { |pipe| pipe.write "failure\n" }
}.to raise_error(ErrorDuringExecution) }.to raise_error(ErrorDuringExecution)
expect($CHILD_STATUS).to be_a_failure expect($CHILD_STATUS).to be_a_failure
end end