From 845cb99e29b7f37573eb9e499b1aed16ee6e7149 Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Wed, 6 Jun 2018 13:13:45 +0200 Subject: [PATCH] Ignore `HOMEBREW_NO_GITHUB_API` when testing. --- Library/Homebrew/dev-cmd/tests.rb | 8 ++------ Library/Homebrew/test/cask/cli/search_spec.rb | 1 - 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/Library/Homebrew/dev-cmd/tests.rb b/Library/Homebrew/dev-cmd/tests.rb index 8eabbf4558..183f67d806 100644 --- a/Library/Homebrew/dev-cmd/tests.rb +++ b/Library/Homebrew/dev-cmd/tests.rb @@ -39,16 +39,12 @@ module Homebrew ENV.delete("HOMEBREW_CASK_OPTS") ENV.delete("HOMEBREW_TEMP") ENV.delete("HOMEBREW_LINKAGE_CACHE") + ENV.delete("HOMEBREW_NO_GITHUB_API") ENV["HOMEBREW_NO_ANALYTICS_THIS_RUN"] = "1" ENV["HOMEBREW_DEVELOPER"] = "1" ENV["HOMEBREW_NO_COMPAT"] = "1" if args.no_compat? ENV["HOMEBREW_TEST_GENERIC_OS"] = "1" if args.generic? - - if args.online? - ENV["HOMEBREW_TEST_ONLINE"] = "1" - else - ENV["HOMEBREW_NO_GITHUB_API"] = "1" - end + ENV["HOMEBREW_TEST_ONLINE"] = "1" if args.online? if args.coverage? ENV["HOMEBREW_TESTS_COVERAGE"] = "1" diff --git a/Library/Homebrew/test/cask/cli/search_spec.rb b/Library/Homebrew/test/cask/cli/search_spec.rb index 57e1206a0f..379a27104d 100644 --- a/Library/Homebrew/test/cask/cli/search_spec.rb +++ b/Library/Homebrew/test/cask/cli/search_spec.rb @@ -3,7 +3,6 @@ require_relative "shared_examples/invalid_option" describe Hbc::CLI::Search, :cask do before do allow(Tty).to receive(:width).and_return(0) - ENV.delete("HOMEBREW_NO_GITHUB_API") end it_behaves_like "a command that handles invalid options"