admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #11182 from Rylan12/deprecate-brew-search-casks

Browse Source 
search: properly deprecate `brew search --cask`
This commit is contained in:
Rylan Polster 2021-04-19 20:06:59 -04:00 committed by GitHub
commit 844f15edec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Library/Homebrew/cmd/search.rb
View File

@ -60,7 +60,8 @@ module Homebrew
conflicts "--open", "--closed" conflicts "--open", "--closed"
conflicts(*package_manager_switches) conflicts(*package_manager_switches)
named_args :text_or_regex, min: 1 # TODO: (3.2) Add `min: 1` the `named_args` once `brew search --cask` is removed
named_args :text_or_regex
end end
end end
@ -73,6 +74,12 @@ module Homebrew
return return
end end
if args.no_named?
odisabled "`brew search --cask` with no arguments to output casks", "`brew casks`" if args.cask?
raise UsageError, "This command requires at least 1 text or regex argument."
end
query = args.named.join(" ") query = args.named.join(" ")
string_or_regex = query_regexp(query) string_or_regex = query_regexp(query)

2
docs/Manpage.md
View File

@ -482,7 +482,7 @@ reinstalled formulae or, every 30 days, for all formulae.
* `--skip-cask-deps`: * `--skip-cask-deps`:
Skip installing cask dependencies. Skip installing cask dependencies.
### `search`, `-S` [*`options`*] *`text`*|`/`*`regex`*`/` [...] ### `search`, `-S` [*`options`*] [*`text`*|`/`*`regex`*`/` ...]
Perform a substring search of cask tokens and formula names for *`text`*. If *`text`* Perform a substring search of cask tokens and formula names for *`text`*. If *`text`*
is flanked by slashes, it is interpreted as a regular expression. is flanked by slashes, it is interpreted as a regular expression.

2
manpages/brew.1
View File

@ -654,7 +654,7 @@ Disable/enable quarantining of downloads (default: enabled)\.
\fB\-\-skip\-cask\-deps\fR \fB\-\-skip\-cask\-deps\fR
Skip installing cask dependencies\. Skip installing cask dependencies\.
. .
.SS "\fBsearch\fR, \fB\-S\fR [\fIoptions\fR] \fItext\fR|\fB/\fR\fIregex\fR\fB/\fR [\.\.\.]" .SS "\fBsearch\fR, \fB\-S\fR [\fIoptions\fR] [\fItext\fR|\fB/\fR\fIregex\fR\fB/\fR \.\.\.]"
Perform a substring search of cask tokens and formula names for \fItext\fR\. If \fItext\fR is flanked by slashes, it is interpreted as a regular expression\. The search for \fItext\fR is extended online to \fBhomebrew/core\fR and \fBhomebrew/cask\fR\. Perform a substring search of cask tokens and formula names for \fItext\fR\. If \fItext\fR is flanked by slashes, it is interpreted as a regular expression\. The search for \fItext\fR is extended online to \fBhomebrew/core\fR and \fBhomebrew/cask\fR\.
. .
.TP .TP