admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #16539 from dduugg/fixed-fixmes

Browse Source 
Remove some fixed FIXMEs
This commit is contained in:
Kevin 2024-01-26 21:14:58 -08:00 committed by GitHub
commit 8392f70620
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/extend/pathname.rb
View File

@ -471,8 +471,7 @@ class Pathname
else else
# Length of the longest regex (currently Tar). # Length of the longest regex (currently Tar).
max_magic_number_length = 262 max_magic_number_length = 262
# FIXME: The `T.let` is a workaround until we have https://github.com/sorbet/sorbet/pull/6865 binread(max_magic_number_length) || ""
T.let(binread(max_magic_number_length), T.nilable(String)) || ""
end end
end end

7
Library/Homebrew/rubocops/cask/mixin/cask_help.rb
View File

@ -14,13 +14,6 @@ module RuboCop
sig { overridable.params(cask_stanza_block: RuboCop::Cask::AST::StanzaBlock).void } sig { overridable.params(cask_stanza_block: RuboCop::Cask::AST::StanzaBlock).void }
def on_cask_stanza_block(cask_stanza_block); end def on_cask_stanza_block(cask_stanza_block); end
# FIXME: Workaround until https://github.com/rubocop/rubocop/pull/11858 is released.
def find_end_line(node)
return node.loc.end.line if node.block_type? || node.numblock_type?
super
end
sig { params(block_node: RuboCop::AST::BlockNode).void } sig { params(block_node: RuboCop::AST::BlockNode).void }
def on_block(block_node) def on_block(block_node)
super if defined? super super if defined? super