Merge pull request #17286 from Homebrew/stricter_linkage_test

linkage_checker: test indirect dependencies.
This commit is contained in:
Carlo Cabrera 2024-05-14 11:59:26 +08:00 committed by GitHub
commit 8378cc825d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -67,6 +67,7 @@ class LinkageChecker
display_items("Conflicting libraries", @version_conflict_deps, puts_output:)
return unless strict
display_items("Indirect dependencies with linkage", @indirect_deps, puts_output:)
display_items("Undeclared dependencies with linkage", @undeclared_deps, puts_output:)
display_items("Files with missing rpath", @files_missing_rpaths, puts_output:)
display_items "@executable_path references in libraries", @executable_path_dylibs, puts_output:
@ -79,7 +80,7 @@ class LinkageChecker
issues = [@broken_deps, @broken_dylibs]
if test
issues += [@unwanted_system_dylibs, @version_conflict_deps]
issues += [@undeclared_deps, @files_missing_rpaths, @executable_path_dylibs] if strict
issues += [@indirect_deps, @undeclared_deps, @files_missing_rpaths, @executable_path_dylibs] if strict
end
issues.any?(&:present?)
end