From 82e314c4674598552ad7f469377b47772ca64a05 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 21 Aug 2019 08:54:05 +0100 Subject: [PATCH] messages_spec: handle frozen Homebrew.args. This is an order dependent test failure fix as seen in https://travis-ci.org/Homebrew/homebrew-test-bot/builds/574559080 --- Library/Homebrew/test/messages_spec.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/test/messages_spec.rb b/Library/Homebrew/test/messages_spec.rb index f11736ac00..8b743b7bdf 100644 --- a/Library/Homebrew/test/messages_spec.rb +++ b/Library/Homebrew/test/messages_spec.rb @@ -72,9 +72,11 @@ describe Messages do end end + # Homebrew.args OpenStruct usage cannot use verified doubles. + # rubocop:disable RSpec/VerifiedDoubles context "when the --display-times argument is present" do before do - allow(Homebrew.args).to receive(:display_times?).and_return(true) + allow(Homebrew).to receive(:args).and_return(double(display_times?: true)) end context "when install_times is empty" do @@ -101,12 +103,13 @@ describe Messages do context "when the --display-times argument isn't present" do before do - allow(ARGV).to receive(:include?).with("--display-times").and_return(false) + allow(Homebrew).to receive(:args).and_return(double(display_times?: false)) end it "doesn't print installation times" do expect { messages.display_messages }.not_to output.to_stdout end end + # rubocop:enable RSpec/VerifiedDoubles end end