admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: Keg-only :provided_by_macos dep okay on Linux

Browse Source 
Disable this brew audit error on Linux:
* Dependency 'zlib' may be unnecessary as it is provided by macOS;
try to build this formula without it.
This commit is contained in:
Shaun Jackman 2019-03-02 12:59:26 -08:00
parent d6e7c9f132
commit 82da3b43cc
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/dev-cmd/audit.rb
View File

@ -386,10 +386,10 @@ module Homebrew
problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'." problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'."
end end
if @new_formula && dep_f.keg_only_reason && if @new_formula &&
!["openssl", "apr", "apr-util"].include?(dep.name) && dep_f.keg_only_reason&.reason == :provided_by_macos &&
!["openblas"].include?(dep.name) && dep_f.keg_only_reason.valid? &&
dep_f.keg_only_reason.reason == :provided_by_macos !["apr", "apr-util", "openblas", "openssl"].include?(dep.name)
new_formula_problem( new_formula_problem(
"Dependency '#{dep.name}' may be unnecessary as it is provided " \ "Dependency '#{dep.name}' may be unnecessary as it is provided " \
"by macOS; try to build this formula without it.", "by macOS; try to build this formula without it.",

2
Library/Homebrew/test/dev-cmd/audit_spec.rb
View File

@ -252,7 +252,7 @@ module Homebrew
its(:problems) { are_expected.to be_empty } its(:problems) { are_expected.to be_empty }
end end
describe "which is not whitelisted" do describe "which is not whitelisted", :needs_macos do
subject { fa } subject { fa }
let(:fa) do let(:fa) do