Added better check for HTTP git URLs

This commit is contained in:
David Broder-Rodgers 2017-01-24 20:35:07 +00:00
parent a731f4e17c
commit 81b3368c9c

View File

@ -1490,15 +1490,15 @@ class ResourceAuditor
return unless @online return unless @online
urls.each do |url| urls.each do |url|
if url.start_with? "http", "ftp" if url.start_with?("git") || url.end_with?(".git")
unless Utils.git_remote_exists url
problem "The URL #{url} is not a valid git URL"
end
elsif url.start_with? "http", "ftp"
status_code = FormulaAuditor.url_status_code url status_code = FormulaAuditor.url_status_code url
unless status_code.start_with? "2" unless status_code.start_with? "2"
problem "The URL #{url} is not reachable (HTTP status code #{status_code})" problem "The URL #{url} is not reachable (HTTP status code #{status_code})"
end end
elsif url.start_with? "git"
unless Utils.git_remote_exists url
problem "The URL #{url} is not a valid git URL"
end
elsif url.start_with? "svn" elsif url.start_with? "svn"
unless Utils.svn_remote_exists url unless Utils.svn_remote_exists url
problem "The URL #{url} is not a valid svn URL" problem "The URL #{url} is not a valid svn URL"