admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

bump-formula-pr: improve duplicate detection

Browse Source 
Reduce the chance of false flagging by making sure that the existing pr
surfaced by GitHub.issues_for_formula actually contains the exact formula name
in its title.
This commit is contained in:
Zhiming Wang 2017-02-18 10:16:59 -05:00
parent 61a41d0da6
commit 81a7609213
No known key found for this signature in database
GPG Key ID: 5B58F95EC95965D8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/dev-cmd/bump-formula-pr.rb
View File

@ -80,7 +80,8 @@ module Homebrew
def fetch_pull_requests(formula) def fetch_pull_requests(formula)
GitHub.issues_for_formula(formula.name, tap: formula.tap).select do |pr| GitHub.issues_for_formula(formula.name, tap: formula.tap).select do |pr|
pr["html_url"].include?("/pull/") pr["html_url"].include?("/pull/") &&
/(^|\s)#{Regexp.quote(formula.name)}(:|\s|$)/i =~ pr["title"]
end end
rescue GitHub::RateLimitExceededError => e rescue GitHub::RateLimitExceededError => e
opoo e.message opoo e.message