admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Make brew typecheck --update --suggest-typed bump strictness further

Browse Source 
- Not only `false` to `true` but `true` to `strict`.
- Only humans every run this, but our goal is to increase the
  typechecking in our files to get to `strict` everywhere so
  let's make that easy to remember to do.
This commit is contained in:
Issy Long 2024-06-02 18:48:30 +01:00
parent 11f042e387
commit 80be27dc9b
No known key found for this signature in database
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/dev-cmd/typecheck.rb
View File

@ -58,10 +58,12 @@ module Homebrew
safe_system "bundle", "exec", "parlour" safe_system "bundle", "exec", "parlour"
if args.suggest_typed? if args.suggest_typed?
ohai "Bumping Sorbet `typed` sigils..." ohai "Checking if we can bump Sorbet `typed` sigils..."
# --sorbet needed because of https://github.com/Shopify/spoom/issues/488 # --sorbet needed because of https://github.com/Shopify/spoom/issues/488
safe_system "bundle", "exec", "spoom", "srb", "bump", "--dry", "--sorbet", safe_system "bundle", "exec", "spoom", "srb", "bump", "--dry", "--from", "false", "--to", "true",
"#{Gem.bin_path("sorbet", "srb")} tc" "--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc"
safe_system "bundle", "exec", "spoom", "srb", "bump", "--dry", "--from", "true", "--to", "strict",
"--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc"
end end
return return