From 8035afcc36ac45ebd127f670b13ab32414c310fa Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 25 Apr 2018 12:08:33 +0100 Subject: [PATCH] linkage_checker: fix generic pathname calls. --- Library/Homebrew/extend/pathname.rb | 8 ++++++++ Library/Homebrew/linkage_checker.rb | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/extend/pathname.rb b/Library/Homebrew/extend/pathname.rb index ec7293496e..dfe24b7886 100644 --- a/Library/Homebrew/extend/pathname.rb +++ b/Library/Homebrew/extend/pathname.rb @@ -472,9 +472,17 @@ class Pathname } end + def binary_executable? + false + end + def mach_o_bundle? false end + + def dylib? + false + end end require "extend/os/pathname" diff --git a/Library/Homebrew/linkage_checker.rb b/Library/Homebrew/linkage_checker.rb index 85bb003a3f..bf390c4270 100644 --- a/Library/Homebrew/linkage_checker.rb +++ b/Library/Homebrew/linkage_checker.rb @@ -66,7 +66,7 @@ class LinkageChecker checked_dylibs = Set.new @keg.find do |file| next if file.symlink? || file.directory? - next unless file.dylib? || file.binary_executable? || file.mach_o_bundle? + next if !file.dylib? && !file.binary_executable? && !file.mach_o_bundle? # weakly loaded dylibs may not actually exist on disk, so skip them # when checking for broken linkage