admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: check for build-time dependencies

Browse Source 
This can be made more robust in the future when we stop throwing away
the ':build' type flag in Formula#depends_on.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Jack Nagel 2011-11-29 19:37:39 -06:00
parent d0b904a6e4
commit 7f7391243a
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Library/Homebrew/cmd/audit.rb
View File

@ -29,6 +29,11 @@ def audit_formula_text name, text
problems << " * Check indentation of 'depends_on'." problems << " * Check indentation of 'depends_on'."
end end
# cmake, pkg-config, and scons are build-time deps
if text =~ /depends_on ['"](cmake|pkg-config|scons)['"]$/
problems << " * #{$1} dependency should be \"depends_on '#{$1}' => :build\""
end
# FileUtils is included in Formula # FileUtils is included in Formula
if text =~ /FileUtils\.(\w+)/ if text =~ /FileUtils\.(\w+)/
problems << " * Don't need 'FileUtils.' before #{$1}." problems << " * Don't need 'FileUtils.' before #{$1}."