admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

rubocops/urls: rename formulae to offense_list

Browse Source
This commit is contained in:
Seeker 2021-01-15 08:26:50 -08:00
parent 1d8372cbc8
commit 7e75d8342b
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Library/Homebrew/test/rubocops/urls_spec.rb
View File

@ -6,7 +6,7 @@ require "rubocops/urls"
describe RuboCop::Cop::FormulaAudit::Urls do
subject(:cop) { described_class.new }
let(:formulae) {
let(:offense_list) {
[{
"url" => "https://ftpmirror.gnu.org/lightning/lightning-2.1.0.tar.gz",
"msg" => 'Please use "https://ftp.gnu.org/gnu/lightning/lightning-2.1.0.tar.gz" instead of https://ftpmirror.gnu.org/lightning/lightning-2.1.0.tar.gz.',
@ -184,20 +184,20 @@ describe RuboCop::Cop::FormulaAudit::Urls do
}
context "when auditing URLs" do
it "reports any offenses" do
formulae.each do |formula|
it "reports all offenses in `offense_list`" do
offense_list.each do |offense_info|
allow_any_instance_of(RuboCop::Cop::FormulaCop).to receive(:formula_tap)
.and_return(formula["formula_tap"])
.and_return(offense_info["formula_tap"])
source = <<~RUBY
class Foo < Formula
desc "foo"
url "#{formula["url"]}"
url "#{offense_info["url"]}"
end
RUBY
expected_offenses = [{ message: formula["msg"],
expected_offenses = [{ message: offense_info["msg"],
severity: :convention,
line: 3,
column: formula["col"],
column: offense_info["col"],
source: source }]
offenses = inspect_source(source)