From 7e6c274f8129b65763a70d7628af8fac0cf40ad0 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Thu, 27 Sep 2012 17:45:06 -0500 Subject: [PATCH] test_bucket: don't try to clean a non-existent keg It is a no-op under Ruby 1.8 but Pathname#find raises ENOENT if the directory doesn't exist under 1.9. But we really shouldn't try to clean a non-existent keg anyway, and FormulaInstaller will have bailed out long before the clean step if the keg doesn't exist, so lets just not even test this condition; the cleaner has its own tests anyway. Alternatively we can adjust the cleaner to handle this case, but I don't see much value in that. n.b. with this, the tests now pass under 1.9.3 (for me), which is nice because I often run them on that version inadvertently. Signed-off-by: Jack Nagel --- Library/Homebrew/test/test_bucket.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/Library/Homebrew/test/test_bucket.rb b/Library/Homebrew/test/test_bucket.rb index 2963a5532b..1279d2ac26 100644 --- a/Library/Homebrew/test/test_bucket.rb +++ b/Library/Homebrew/test/test_bucket.rb @@ -84,7 +84,6 @@ class BeerTasting < Test::Unit::TestCase assert_nothing_raised do f=TestBallWithRealPath.new Homebrew.info_formula f - Cleaner.new f Homebrew.prune #TODO test diy function too end