admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: check for ARGV.flag? in formulae

Browse Source 
We don't want single letter options like '-v' or '-d' to unintentionally
trigger formula-specific options.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Jack Nagel 2011-11-18 15:22:04 -06:00
parent 6c4d3a15d6
commit 7e57847793
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Library/Homebrew/cmd/audit.rb
View File

@ -120,6 +120,11 @@ def audit_formula_text name, text
problems << " * xcodebuild should be passed an explicit \"SYMROOT\"" problems << " * xcodebuild should be passed an explicit \"SYMROOT\""
end if strict? end if strict?
# using ARGV.flag? for formula options is generally a bad thing
if text =~ /ARGV\.flag\?/
problems << " * Use 'ARGV.include?' instead of 'ARGV.flag?'"
end
return problems return problems
end end
@ -128,7 +133,7 @@ def audit_formula_options f, text
# Find possible options # Find possible options
options = [] options = []
text.scan(/ARGV\.(include|flag)\?[ ]*\(?(['"])(.+?)\2/) { |m| options << m[2] } text.scan(/ARGV\.include\?[ ]*\(?(['"])(.+?)\1/) { |m| options << m[1] }
options.reject! {|o| o.include? "#"} options.reject! {|o| o.include? "#"}
options.uniq! options.uniq!