Deprecate/disable/delete code.

The next release after this is merged will be 4.1.0.

Co-authored-by: Markus Reiter <me@reitermark.us>

Library/Homebrew/cask/audit.rb

@@ -265,13 +265,6 @@ module Cask
       add_error "cannot use the sha256 for an empty string: #{empty_sha256}"
     end
 
-    sig { void }
-    def audit_appcast
-      return unless cask.appcast
-
-      add_error "`appcast` should be replaced with a `livecheck`."
-    end
-
     sig { void }
     def audit_latest_with_livecheck
       return unless cask.version.latest?

Library/Homebrew/cask/cask.rb

@@ -26,7 +26,7 @@ module Cask
     def self.all
       # TODO: ideally avoid using ARGV by moving to e.g. CLI::Parser
       if ARGV.exclude?("--eval-all") && !Homebrew::EnvConfig.eval_all?
-        odeprecated "Cask::Cask#all without --all or HOMEBREW_EVAL_ALL"
+        odisabled "Cask::Cask#all without --eval-all or HOMEBREW_EVAL_ALL"
       end
 
       Tap.flat_map(&:cask_files).map do |f|

Library/Homebrew/cask/download.rb

@@ -34,7 +34,7 @@ module Cask
 
     sig { override.returns(T.nilable(Version)) }
     def version
-      @version ||= Version.create(cask.version)
+      @version ||= Version.new(cask.version)
     end
 
     sig {

Library/Homebrew/cask/dsl.rb

@@ -211,8 +211,7 @@ module Cask
     # @api public
     def appcast(*args, **kwargs)
       set_unique_stanza(:appcast, args.empty? && kwargs.empty?) do
-        # TODO: Remove the remaining audit for `appcast` usage when enabling this deprecation.
+        odeprecated "the `appcast` stanza", "the `livecheck` stanza"
-        # odeprecated "the `appcast` stanza", "the `livecheck` stanza"
         true
       end
     end

Library/Homebrew/cask/dsl/postflight.rb

@@ -11,8 +11,8 @@ module Cask
     class Postflight < Base
       include Staged
 
-      def suppress_move_to_applications(options = {})
+      def suppress_move_to_applications(_options = {})
-        # TODO: Remove from all casks because it is no longer needed
+        odeprecated "Cask::DSL#suppress_move_to_applications"
       end
     end
   end

Library/Homebrew/cli/args.rb

@@ -112,7 +112,7 @@ module Homebrew
           skip_invalid_combinations = true
 
           [
-            *MacOSVersions::SYMBOLS.keys,
+            *MacOSVersion::SYMBOLS.keys,
             :linux,
           ]
         else

Library/Homebrew/cli/parser.rb

@@ -166,6 +166,7 @@ module Homebrew
           description += " (disabled#{"; replaced by #{replacement}" if replacement.present?})"
         end
         @parser.public_send(method, *names, *wrap_option_desc(description)) do |value|
+          # This odeprecated should stick around indefinitely.
           odeprecated "the `#{names.first}` switch", replacement, disable: disable if !replacement.nil? || disable
           value = true if names.none? { |name| name.start_with?("--[no-]") }
 
@@ -224,6 +225,7 @@ module Homebrew
           description += " (disabled#{"; replaced by #{replacement}" if replacement.present?})"
         end
         @parser.on(*names, *wrap_option_desc(description), required) do |option_value|
+          # This odisabled should stick around indefinitely.
           odisabled "the `#{names.first}` flag", replacement unless replacement.nil?
           names.each do |name|
             @args[option_to_name(name)] = option_value

Library/Homebrew/cmd/--cache.rb

@@ -27,7 +27,8 @@ module Homebrew
       switch "--force-bottle",
              description: "Show the cache file used when pouring a bottle."
       flag "--bottle-tag=",
-           description: "Show the cache file used when pouring a bottle for the given tag."
+           description: "Show the cache file used when pouring a bottle for the given tag.",
+           hidden:      true
       switch "--HEAD",
              description: "Show the cache file used when building from HEAD."
       switch "--formula", "--formulae",
@@ -96,7 +97,7 @@ module Homebrew
       arch:                       args.arch&.to_sym,
     )
       bottle_tag = if (bottle_tag = args.bottle_tag&.to_sym)
-        # TODO: odeprecate "--bottle-tag"
+        odeprecated "brew --cache --bottle-tag", "brew --cache --os --arch"
         Utils::Bottles::Tag.from_symbol(bottle_tag)
       else
         Utils::Bottles::Tag.new(system: os, arch: arch)

Library/Homebrew/cmd/deps.rb

@@ -54,8 +54,6 @@ module Homebrew
       switch "--eval-all",
              description: "Evaluate all available formulae and casks, whether installed or not, to list " \
                           "their dependencies."
-      switch "--all",
-             hidden:      true
       switch "--for-each",
              description: "Switch into the mode used by the `--all` option, but only list dependencies " \
                           "for each provided <formula>, one formula per line. This is used for " \
@@ -80,13 +78,6 @@ module Homebrew
     args = deps_args.parse
 
     all = args.eval_all?
-    if args.all?
-      unless all
-        odisabled "brew deps --all",
-                  "brew deps --eval-all or HOMEBREW_EVAL_ALL"
-      end
-      all = true
-    end
 
     Formulary.enable_factory_cache!
 

Library/Homebrew/cmd/desc.rb

@@ -43,7 +43,7 @@ module Homebrew
     args = desc_args.parse
 
     if !args.eval_all? && !Homebrew::EnvConfig.eval_all?
-      odisabled "brew desc", "brew desc --eval-all or HOMEBREW_EVAL_ALL"
+      raise UsageError, "`brew desc` needs `--eval-all` passed or `HOMEBREW_EVAL_ALL` set!"
     end
 
     search_type = if args.search?

Library/Homebrew/cmd/info.rb

@@ -59,9 +59,6 @@ module Homebrew
              depends_on:  "--json",
              description: "Evaluate all available formulae and casks, whether installed or not, to print their " \
                           "JSON. Implied if `HOMEBREW_EVAL_ALL` is set."
-      switch "--all",
-             hidden:     true,
-             depends_on: "--json"
       switch "--variations",
              depends_on:  "--json",
              description: "Include the variations hash in each formula's JSON output."
@@ -103,10 +100,6 @@ module Homebrew
       print_analytics(args: args)
     elsif args.json
       all = args.eval_all?
-      if !all && args.all? && !Homebrew::EnvConfig.eval_all?
-        odisabled "brew info --all", "brew info --eval-all or HOMEBREW_EVAL_ALL"
-        all = true
-      end
 
       print_json(all, args: args)
     elsif args.github?

Library/Homebrew/cmd/install.rb

@@ -170,6 +170,7 @@ module Homebrew
       # Can't use `replacement: false` because `install_args` are used by
       # `build.rb`. Instead, `hide_from_man_page` and don't do anything with
       # this argument here.
+      # This odisabled should stick around indefinitely.
       odisabled "brew install --env", "`env :std` in specific formula files"
     end
 

Library/Homebrew/cmd/options.rb

@@ -20,8 +20,6 @@ module Homebrew
       switch "--eval-all",
              description: "Evaluate all available formulae and casks, whether installed or not, to show their " \
                           "options."
-      switch "--all",
-             hidden: true
       flag   "--command=",
              description: "Show options for the specified <command>."
 
@@ -35,10 +33,6 @@ module Homebrew
     args = options_args.parse
 
     all = args.eval_all?
-    if args.all?
-      odisabled "brew info --all", "brew info --eval-all" if !all && !Homebrew::EnvConfig.eval_all?
-      all = true
-    end
 
     if all
       puts_options Formula.all.sort, args: args

Library/Homebrew/cmd/readall.rb

@@ -38,9 +38,7 @@ module Homebrew
   def readall
     args = readall_args.parse
 
-    if args.no_simulate?
+    odeprecated "--no-simulate", "nothing (i.e. not passing `--os` or `--arch`)" if args.no_simulate?
-      # odeprecated "--no-simulate", "nothing (i.e. not passing `--os` or `--arch`)"
-    end
 
     if args.syntax? && args.no_named?
       scan_files = "#{HOMEBREW_LIBRARY_PATH}/**/*.rb"
@@ -57,8 +55,9 @@ module Homebrew
     options[:os_arch_combinations] = args.os_arch_combinations if args.os || args.arch
     taps = if args.no_named?
       if !args.eval_all? && !Homebrew::EnvConfig.eval_all?
-        odisabled "brew readall", "brew readall --eval-all or HOMEBREW_EVAL_ALL"
+        raise UsageError, "`brew readall` needs a tap or `--eval-all` passed or `HOMEBREW_EVAL_ALL` set!"
       end
+
       Tap
     else
       args.named.to_installed_taps

Library/Homebrew/cmd/search.rb

@@ -75,8 +75,9 @@ module Homebrew
 
     if args.desc?
       if !args.eval_all? && !Homebrew::EnvConfig.eval_all?
-        odisabled "brew search --desc", "brew search --desc --eval-all or HOMEBREW_EVAL_ALL"
+        raise UsageError, "`brew search --desc` needs `--eval-all` passed or `HOMEBREW_EVAL_ALL` set!"
       end
+
       Search.search_descriptions(string_or_regex, args)
     elsif args.pull_request?
       search_pull_requests(query, args)

Library/Homebrew/cmd/update-report.rb

@@ -743,7 +743,7 @@ class ReporterHub
   def dump(auto_update: false)
     report_all = ENV["HOMEBREW_UPDATE_REPORT_ALL_FORMULAE"].present?
     if report_all && !Homebrew::EnvConfig.no_install_from_api?
-      odeprecated "HOMEBREW_UPDATE_REPORT_ALL_FORMULAE"
+      odisabled "HOMEBREW_UPDATE_REPORT_ALL_FORMULAE"
       opoo "This will not report all formulae because Homebrew cannot get this data from the API."
       report_all = false
     end

Library/Homebrew/cmd/uses.rb

@@ -32,8 +32,6 @@ module Homebrew
       switch "--eval-all",
              description: "Evaluate all available formulae and casks, whether installed or not, to show " \
                           "their dependents."
-      switch "--all",
-             hidden: true
       switch "--include-build",
              description: "Include all formulae that specify <formula> as `:build` type dependency."
       switch "--include-test",
@@ -110,17 +108,11 @@ module Homebrew
       deps
     else
       all = args.eval_all?
-      if args.all?
-        unless all
-          odisabled "brew uses --all",
-                    "brew uses --eval-all or HOMEBREW_EVAL_ALL"
-        end
-        all = true
-      end
 
       if !args.installed? && !(all || Homebrew::EnvConfig.eval_all?)
-        odisabled "brew uses", "brew uses --eval-all or HOMEBREW_EVAL_ALL"
+        raise UsageError, "`brew uses` needs `--installed` or `--eval-all` passed or `HOMEBREW_EVAL_ALL` set!"
       end
+
       if show_formulae_and_casks || args.formula?
         deps += args.installed? ? Formula.installed : Formula.all
       end

Library/Homebrew/dev-cmd/audit.rb

@@ -44,15 +44,10 @@ module Homebrew
       switch "--eval-all",
              description: "Evaluate all available formulae and casks, whether installed or not, to audit them. " \
                           "Implied if `HOMEBREW_EVAL_ALL` is set."
-      switch "--all",
-             hidden: true
       switch "--new", "--new-formula", "--new-cask",
              description: "Run various additional style checks to determine if a new formula or cask is eligible " \
                           "for Homebrew. This should be used when creating new formula and implies " \
                           "`--strict` and `--online`."
-      switch "--[no-]appcast",
-             description: "Audit the appcast.",
-             replacement: false
       switch "--[no-]signing",
              description: "Audit for signed apps, which are required on ARM"
       switch "--token-conflicts",
@@ -136,6 +131,7 @@ module Homebrew
         [Formula.installed, Cask::Caskroom.casks]
       elsif args.no_named?
         if !args.eval_all? && !Homebrew::EnvConfig.eval_all?
+          # This odisabled should probably stick around indefinitely.
           odisabled "brew audit",
                     "brew audit --eval-all or HOMEBREW_EVAL_ALL"
         end
@@ -143,8 +139,8 @@ module Homebrew
         [Formula.all, Cask::Cask.all]
       else
         if args.named.any? { |named_arg| named_arg.end_with?(".rb") }
-          odeprecated "brew audit [path ...]",
+          odisabled "brew audit [path ...]",
-                      "brew audit [name ...]"
+                    "brew audit [name ...]"
         end
 
         args.named.to_formulae_and_casks
@@ -235,7 +231,7 @@ module Homebrew
       require "cask/auditor"
 
       if args.display_failures_only?
-        odeprecated "`brew audit <cask> --display-failures-only`", "`brew audit <cask>` without the argument"
+        odisabled "`brew audit <cask> --display-failures-only`", "`brew audit <cask>` without the argument"
       end
     end
 

Library/Homebrew/dev-cmd/bump-formula-pr.rb

@@ -474,7 +474,7 @@ module Homebrew
     name, old_alias_version = versioned_alias.split("@")
     new_alias_regex = (old_alias_version.split(".").length == 1) ? /^\d+/ : /^\d+\.\d+/
     new_alias_version, = *new_formula_version.to_s.match(new_alias_regex)
-    return if Version.create(new_alias_version) <= Version.create(old_alias_version)
+    return if Version.new(new_alias_version) <= Version.new(old_alias_version)
 
     [versioned_alias, "#{name}@#{new_alias_version}"]
   end

Library/Homebrew/dev-cmd/create.rb

@@ -101,7 +101,7 @@ module Homebrew
     raise Cask::CaskAlreadyCreatedError, token if cask_path.exist?
 
     version = if args.set_version
-      Version.create(args.set_version)
+      Version.new(args.set_version)
     else
       Version.detect(url.gsub(token, "").gsub(/x86(_64)?/, ""))
     end

Library/Homebrew/dev-cmd/generate-man-completions.rb

@@ -14,12 +14,6 @@ module Homebrew
       description <<~EOS
         Generate Homebrew's manpages and shell completions.
       EOS
-      switch "--fail-if-not-changed",
-             hidden:      true,
-             description: "Return a failing status code if no changes are detected in the manpage outputs. " \
-                          "This can be used to notify CI when the manpages are out of date. Additionally, " \
-                          "the date used in new manpages will match those in the existing manpages (to allow " \
-                          "comparison without factoring in the date)."
       named_args :none
     end
   end
@@ -27,8 +21,6 @@ module Homebrew
   def generate_man_completions
     args = generate_man_completions_args.parse
 
-    odisabled "brew generate-man-completions --fail-if-not-changed" if args.fail_if_not_changed?
-
     Commands.rebuild_internal_commands_completion_list
     Manpages.regenerate_man_pages(quiet: args.quiet?)
     Completions.update_shell_completions!

Library/Homebrew/dev-cmd/livecheck.rb

@@ -27,8 +27,6 @@ module Homebrew
              description: "Check formulae and casks within the given tap, specified as <user>`/`<repo>."
       switch "--eval-all",
              description: "Evaluate all available formulae and casks, whether installed or not, to check them."
-      switch "--all",
-             hidden: true
       switch "--installed",
              description: "Check formulae and casks that are currently installed."
       switch "--newer-only",
@@ -56,10 +54,6 @@ module Homebrew
     args = livecheck_args.parse
 
     all = args.eval_all?
-    if args.all?
-      odisabled "brew livecheck --all", "brew livecheck --eval-all" if !all && !Homebrew::EnvConfig.eval_all?
-      all = true
-    end
 
     if args.debug? && args.verbose?
       puts args

Library/Homebrew/dev-cmd/pr-publish.rb

@@ -39,7 +39,7 @@ module Homebrew
   def pr_publish
     args = pr_publish_args.parse
 
-    odeprecated "`brew pr-publish --no-autosquash`" if args.no_autosquash?
+    odisabled "`brew pr-publish --no-autosquash`" if args.no_autosquash?
 
     tap = Tap.fetch(args.tap || CoreTap.instance.name)
     workflow = args.workflow || "publish-commit-bottles.yml"

Library/Homebrew/dev-cmd/typecheck.rb

@@ -21,10 +21,6 @@ module Homebrew
       switch "--suggest-typed",
              depends_on:  "--update",
              description: "Try upgrading `typed` sigils."
-      switch "--fail-if-not-changed",
-             hidden:      true,
-             description: "Return a failing status code if all gems are up to date " \
-                          "and gem definitions do not need a tapioca update."
       flag   "--dir=",
              description: "Typecheck all files in a specific directory."
       flag   "--file=",
@@ -49,8 +45,6 @@ module Homebrew
 
     HOMEBREW_LIBRARY_PATH.cd do
       if update
-        odisabled "brew typecheck --update --fail-if-not-changed" if args.fail_if_not_changed?
-
         excluded_gems = [
           "did_you_mean", # RBI file is already provided by Sorbet
           "webrobots", # RBI file is bugged

Library/Homebrew/dev-cmd/unbottled.rb

@@ -56,8 +56,9 @@ module Homebrew
       all = args.eval_all?
       if args.total?
         if !all && !Homebrew::EnvConfig.eval_all?
-          odisabled "brew unbottled --total", "brew unbottled --total --eval-all or HOMEBREW_EVAL_ALL"
+          raise UsageError, "`brew unbottled --total` needs `--eval-all` passed or `HOMEBREW_EVAL_ALL` set!"
         end
+
         all = true
       end
 
@@ -99,8 +100,9 @@ module Homebrew
       formulae = all_formulae = args.named.to_formulae
     elsif args.dependents?
       if !args.eval_all? && !Homebrew::EnvConfig.eval_all?
-        odisabled "brew unbottled --dependents", "brew unbottled --all --dependents or HOMEBREW_EVAL_ALL"
+        raise UsageError, "`brew unbottled --dependents` needs `--eval-all` passed or `HOMEBREW_EVAL_ALL` set!"
       end
+
       formulae = all_formulae = Formula.all
 
       @sort = " (sorted by number of dependents)"

Library/Homebrew/dev-cmd/update-license-data.rb

@@ -16,18 +16,12 @@ module Homebrew
       description <<~EOS
         Update SPDX license data in the Homebrew repository.
       EOS
-      switch "--fail-if-not-changed",
-             hidden:      true,
-             description: "Return a failing status code if current license data's version is the same as " \
-                          "the upstream. This can be used to notify CI when the SPDX license data is out of date."
-
       named_args :none
     end
   end
 
   def update_license_data
-    args = update_license_data_args.parse
+    update_license_data_args.parse
-    odisabled "brew update-license-data --fail-if-not-changed" if args.fail_if_not_changed?
 
     SPDX.download_latest_license_data!
     diff = system_command "git", args: [

Library/Homebrew/diagnostic.rb

@@ -473,7 +473,7 @@ module Homebrew
       def check_git_version
         minimum_version = ENV.fetch("HOMEBREW_MINIMUM_GIT_VERSION")
         return unless Utils::Git.available?
-        return if Version.create(Utils::Git.version) >= Version.create(minimum_version)
+        return if Version.new(Utils::Git.version) >= Version.new(minimum_version)
 
         git = Formula["git"]
         git_upgrade_cmd = git.any_version_installed? ? "upgrade" : "install"

Library/Homebrew/download_strategy.rb

@@ -737,7 +737,7 @@ class SubversionDownloadStrategy < VCSDownloadStrategy
   # @api public
   sig { returns(Time) }
   def source_modified_time
-    time = if Version.create(T.must(Utils::Svn.version)) >= Version.create("1.9")
+    time = if Version.new(T.must(Utils::Svn.version)) >= Version.new("1.9")
       out, = silent_command("svn", args: ["info", "--show-item", "last-changed-date"], chdir: cached_location)
       out
     else

Library/Homebrew/extend/kernel.rb

@@ -157,6 +157,7 @@ module Kernel
 
   def odisabled(method, replacement = nil, options = {})
     options = { disable: true, caller: caller }.merge(options)
+    # This odeprecated should stick around indefinitely.
     odeprecated(method, replacement, options)
   end
 
@@ -318,7 +319,7 @@ module Kernel
 
   # GZips the given paths, and returns the gzipped paths.
   def gzip(*paths)
-    odeprecated "Utils.gzip", "Utils::Gzip.compress"
+    odisabled "Utils.gzip", "Utils::Gzip.compress"
     Utils::Gzip.compress(*paths)
   end
 
@@ -503,13 +504,13 @@ module Kernel
 
   sig { returns(String) }
   def preferred_shell
-    odeprecated "preferred_shell"
+    odisabled "preferred_shell"
     Utils::Shell.preferred_path(default: "/bin/sh")
   end
 
   sig { returns(String) }
   def shell_profile
-    odeprecated "shell_profile"
+    odisabled "shell_profile"
     Utils::Shell.profile
   end
 

Library/Homebrew/extend/os/linux/linkage_checker.rb

@@ -26,47 +26,11 @@ class LinkageChecker
     libquadmath.so.0
   ].freeze
 
-  def display_deprecated_warning(strict: false)
-    # Steps when moving these to `odisabled`:
-    # - Remove the old library from SYSTEM_LIBRARY_ALLOWLIST above.
-    # - Remove the `disable` and `disable_for_developer` kwargs here.
-    # - Adjust the `broken_library_linkage?` override below to not check for the library.
-    # - Remove the relevant `fail_on_lib*?`.
-    # If there's no more deprecations left:
-    # - Remove the `broken_library_linkage?` override and the generic alias in HOMEBREW_LIBRARY/linkage_checker.rb.
-    #
-    # Steps when removing handling for a library entirely (assuming the steps to `odisabled` has already been done):
-    # - Remove the relevant setting of `@lib*_found` in `check_dylibs` below.
-    # - Remove the `odisabled` line
-    # If there's no library deprecated/disabled handling left:
-    # - Remove the `display_` overrides here and the associated generic aliases in HOMEBREW_LIBRARY/linkage_checker.rb
-
-    return unless @libnsl_found
-
-    odisabled "linkage to libnsl.so.1", "libnsl.so.3 in the libnsl formula"
-  end
-
-  def display_normal_output
-    generic_display_normal_output
-    display_deprecated_warning
-  end
-
-  def display_test_output(puts_output: true, strict: false)
-    generic_display_test_output(puts_output: puts_output, strict: strict)
-    display_deprecated_warning(strict: strict)
-  end
-
-  def broken_library_linkage?(test: false, strict: false)
-    generic_broken_library_linkage?(test: test, strict: strict) || @libnsl_found
-  end
-
   private
 
   def check_dylibs(rebuild_cache:)
     generic_check_dylibs(rebuild_cache: rebuild_cache)
 
-    @libnsl_found = true if @system_dylibs.any? { |s| File.basename(s) == "libnsl.so.1" }
-
     # glibc and gcc are implicit dependencies.
     # No other linkage to system libraries is expected or desired.
     @unwanted_system_dylibs = @system_dylibs.reject do |s|

Library/Homebrew/formula.rb

@@ -500,7 +500,7 @@ class Formula
   # An old name for the formula.
   # @deprecated Use #{#oldnames} instead.
   def oldname
-    # odeprecated "Formula#oldname", "Formula#oldnames"
+    odeprecated "Formula#oldname", "Formula#oldnames"
     @oldname ||= oldnames.first
   end
 
@@ -1036,7 +1036,7 @@ class Formula
   # The generated launchd {.plist} file path.
   sig { returns(Pathname) }
   def plist_path
-    odeprecated "formula.plist_path", "formula.launchd_service_path"
+    odisabled "formula.plist_path", "formula.launchd_service_path"
     launchd_service_path
   end
 
@@ -1859,7 +1859,7 @@ class Formula
   def self.all
     # TODO: ideally avoid using ARGV by moving to e.g. CLI::Parser
     if ARGV.exclude?("--eval-all") && !Homebrew::EnvConfig.eval_all?
-      odeprecated "Formula#all without --all or HOMEBREW_EVAL_ALL"
+      odisabled "Formula#all without --eval-all or HOMEBREW_EVAL_ALL"
     end
 
     (core_names + tap_files).map do |name_or_file|
@@ -3265,7 +3265,7 @@ class Formula
     #
     # @deprecated Please use {Homebrew::Service.require_root} instead.
     def plist_options(options)
-      odeprecated "plist_options", "service.require_root"
+      odisabled "plist_options", "service.require_root"
       @plist_startup = options[:startup]
       @plist_manual = options[:manual]
     end
@@ -3550,7 +3550,7 @@ class Formula
 
     # Permit links to certain libraries that don't exist. Available on Linux only.
     def ignore_missing_libraries(*libs)
-      odeprecated "ignore_missing_libraries"
+      odisabled "ignore_missing_libraries"
       unless Homebrew::SimulateSystem.simulating_or_running_on_linux?
         raise FormulaSpecificationError, "#{__method__} is available on Linux only"
       end

Library/Homebrew/formula_auditor.rb

@@ -271,7 +271,7 @@ module Homebrew
             next
           end
 
-          if dep_f.oldname && dep.name.split("/").last == dep_f.oldname
+          if dep_f.oldnames.include?(dep.name.split("/").last)
             problem "Dependency '#{dep.name}' was renamed; use new name '#{dep_f.name}'."
           end
 
@@ -699,10 +699,10 @@ module Homebrew
       when %r{download\.gnome\.org/sources}, %r{ftp\.gnome\.org/pub/GNOME/sources}i
         version_prefix = stable.version.major_minor
         return if formula.tap&.audit_exception :gnome_devel_allowlist, formula.name, version_prefix
-        return if stable_url_version < Version.create("1.0")
+        return if stable_url_version < Version.new("1.0")
         # All minor versions are stable in the new GNOME version scheme (which starts at version 40.0)
         # https://discourse.gnome.org/t/new-gnome-versioning-scheme/4235
-        return if stable_url_version >= Version.create("40.0")
+        return if stable_url_version >= Version.new("40.0")
         return if stable_url_minor_version.even?
 
         problem "#{stable.version} is a development release"

Library/Homebrew/formula_creator.rb

@@ -36,7 +36,7 @@ module Homebrew
       end
       update_path
       @version = if @version
-        Version.create(@version)
+        Version.new(@version)
       else
         Version.detect(url)
       end

Library/Homebrew/formula_info.rb

@@ -57,7 +57,7 @@ class FormulaInfo
 
   def version(spec_type)
     version_str = info["versions"][spec_type.to_s]
-    version_str && Version.create(version_str)
+    version_str && Version.new(version_str)
   end
 
   def pkg_version(spec_type = :stable)

Library/Homebrew/linkage_checker.rb

@@ -47,8 +47,6 @@ class LinkageChecker
     display_items "Unwanted system libraries", @unwanted_system_dylibs
     display_items "Files with missing rpath", @files_missing_rpaths
   end
-  alias generic_display_normal_output display_normal_output
-  private :generic_display_normal_output
 
   def display_reverse_output
     return if @reverse_links.empty?
@@ -75,8 +73,6 @@ class LinkageChecker
     display_items "Undeclared dependencies with linkage", @undeclared_deps, puts_output: puts_output
     display_items "Files with missing rpath", @files_missing_rpaths, puts_output: puts_output
   end
-  alias generic_display_test_output display_test_output
-  private :generic_display_test_output
 
   sig { params(test: T::Boolean, strict: T::Boolean).returns(T::Boolean) }
   def broken_library_linkage?(test: false, strict: false)
@@ -89,8 +85,6 @@ class LinkageChecker
     end
     issues.any?(&:present?)
   end
-  alias generic_broken_library_linkage? broken_library_linkage?
-  private :generic_broken_library_linkage?
 
   def unexpected_broken_dylibs
     return @unexpected_broken_dylibs if @unexpected_broken_dylibs

Library/Homebrew/macos_version.rb

@@ -140,28 +140,27 @@ end
 
 require "lazy_object"
 
+module MacOSVersionErrorCompat
+  def const_missing(name)
+    if name == :MacOSVersionError
+      odeprecated "MacOSVersionError", "MacOSVersion::Error"
+      return MacOSVersion::Error
+    end
+
+    super
+  end
+end
+
 # `LazyObject` does not work for exceptions when used in `rescue` statements.
 class Object
   class << self
-    module MacOSVersionErrorCompat
-      def const_missing(name)
-        if name == :MacOSVersionError
-          # odeprecated "MacOSVersionError", "MacOSVersion::Error"
-          return MacOSVersion::Error
-        end
-
-        super
-      end
-    end
-    private_constant :MacOSVersionErrorCompat
-
     prepend MacOSVersionErrorCompat
   end
 end
 
 module MacOSVersions
   SYMBOLS = LazyObject.new do # rubocop:disable Style/MutableConstant
-    # odeprecated "MacOSVersions::SYMBOLS", "MacOSVersion::SYMBOLS"
+    odeprecated "MacOSVersions::SYMBOLS", "MacOSVersion::SYMBOLS"
     MacOSVersion::SYMBOLS
   end
 end
@@ -170,7 +169,7 @@ module OS
   module Mac
     # TODO: Replace `::Version` with `Version` when this is removed.
     Version = LazyObject.new do # rubocop:disable Style/MutableConstant
-      # odeprecated "OS::Mac::Version", "MacOSVersion"
+      odeprecated "OS::Mac::Version", "MacOSVersion"
       MacOSVersion
     end
   end

Library/Homebrew/macos_version.rbi

@@ -0,0 +1,5 @@
+# typed: strict
+
+module MacOSVersionErrorCompat
+  include Kernel
+end

Library/Homebrew/pkg_version.rb

@@ -19,7 +19,7 @@ class PkgVersion
 
   def self.parse(path)
     _, version, revision = *path.match(REGEX)
-    version = Version.create(version)
+    version = Version.new(version)
     new(version, revision.to_i)
   end
 

Library/Homebrew/requirements/macos_requirement.rb

@@ -13,10 +13,10 @@ class MacOSRequirement < Requirement
 
   # TODO: when Yosemite is removed here, keep these around as empty arrays so we
   # can keep the deprecation/disabling code the same.
-  DISABLED_MACOS_VERSIONS = [].freeze
+  DISABLED_MACOS_VERSIONS = [
-  DEPRECATED_MACOS_VERSIONS = [
     :yosemite,
   ].freeze
+  DEPRECATED_MACOS_VERSIONS = [].freeze
 
   def initialize(tags = [], comparator: ">=")
     @version = begin
@@ -27,9 +27,11 @@ class MacOSRequirement < Requirement
       end
     rescue MacOSVersion::Error => e
       if DISABLED_MACOS_VERSIONS.include?(e.version)
-        odisabled "depends_on :macos => :#{e.version}"
+        # This odisabled should stick around indefinitely.
+        odisabled "`depends_on macos: :#{e.version}`"
       elsif DEPRECATED_MACOS_VERSIONS.include?(e.version)
-        odeprecated "depends_on :macos => :#{e.version}"
+        # This odeprecated should stick around indefinitely.
+        odeprecated "`depends_on macos: :#{e.version}`"
       else
         raise
       end

Library/Homebrew/software_spec.rb

@@ -92,7 +92,7 @@ class SoftwareSpec
 
       raise "#{full_name}: version missing for \"#{r.name}\" resource!" if version.nil?
 
-      r.version(version.head? ? Version.create("HEAD") : version.dup)
+      r.version(version.head? ? Version.new("HEAD") : version.dup)
     end
     patches.each { |p| p.owner = self }
   end
@@ -203,17 +203,15 @@ class SoftwareSpec
   end
 
   # @deprecated
-  # rubocop:disable Style/TrivialAccessors
   def uses_from_macos_elements
     # TODO: remove all @uses_from_macos_elements when disabling or removing this method
-    # odeprecated "#uses_from_macos_elements", "#declared_deps"
+    odeprecated "#uses_from_macos_elements", "#declared_deps"
     @uses_from_macos_elements
   end
-  # rubocop:enable Style/TrivialAccessors
 
   # @deprecated
   def uses_from_macos_names
-    # odeprecated "#uses_from_macos_names", "#declared_deps"
+    odeprecated "#uses_from_macos_names", "#declared_deps"
     uses_from_macos_elements.flat_map { |e| e.is_a?(Hash) ? e.keys : e }
   end
 
@@ -282,7 +280,7 @@ end
 class HeadSoftwareSpec < SoftwareSpec
   def initialize(flags: [])
     super
-    @resource.version(Version.create("HEAD"))
+    @resource.version(Version.new("HEAD"))
   end
 
   def verify_download_integrity(_filename)

Library/Homebrew/tap.rb

@@ -508,12 +508,7 @@ class Tap
   sig { returns(T::Array[Pathname]) }
   def formula_files
     @formula_files ||= if formula_dir.directory?
-      # TODO: odeprecate the non-official/old logic with a new minor release somehow?
+      formula_dir.find.select(&method(:formula_file?))
-      if official?
-        formula_dir.find
-      else
-        formula_dir.children
-      end.select(&method(:formula_file?))
     else
       []
     end
@@ -542,12 +537,7 @@ class Tap
   sig { returns(T::Array[Pathname]) }
   def cask_files
     @cask_files ||= if cask_dir.directory?
-      # TODO: odeprecate the non-official/old logic with a new minor release somehow?
+      cask_dir.find.select(&method(:ruby_file?))
-      if official?
-        cask_dir.find
-      else
-        cask_dir.children
-      end.select(&method(:ruby_file?))
     else
       []
     end

Library/Homebrew/test/cask/audit_spec.rb

@@ -832,15 +832,6 @@ describe Cask::Audit, :cask do
       end
     end
 
-    describe "appcast" do
-      context "when the Cask has an appcast" do
-        let(:cask_token) { "with-appcast" }
-        let(:message) { "`appcast` should be replaced with a `livecheck`." }
-
-        it { is_expected.to error_with(message) }
-      end
-    end
-
     describe "denylist checks" do
       let(:only) { ["denylist"] }
 

Library/Homebrew/test/compiler_selector_spec.rb

@@ -9,15 +9,15 @@ describe CompilerSelector do
   let(:compilers) { [:clang, :gnu] }
   let(:software_spec) { SoftwareSpec.new }
   let(:cc) { :clang }
-  let(:versions) { class_double(DevelopmentTools, clang_build_version: Version.create("600")) }
+  let(:versions) { class_double(DevelopmentTools, clang_build_version: Version.new("600")) }
 
   before do
     allow(versions).to receive(:gcc_version) do |name|
       case name
-      when "gcc-7" then Version.create("7.1")
+      when "gcc-7" then Version.new("7.1")
-      when "gcc-6" then Version.create("6.1")
+      when "gcc-6" then Version.new("6.1")
-      when "gcc-5" then Version.create("5.1")
+      when "gcc-5" then Version.new("5.1")
-      when "gcc-4.9" then Version.create("4.9.1")
+      when "gcc-4.9" then Version.new("4.9.1")
       else Version::NULL
       end
     end

Library/Homebrew/test/download_strategies/git_spec.rb

@@ -51,7 +51,7 @@ describe GitDownloadStrategy do
 
   describe "#fetch_last_commit" do
     let(:url) { "file://#{remote_repo}" }
-    let(:version) { Version.create("HEAD") }
+    let(:version) { Version.new("HEAD") }
     let(:remote_repo) { HOMEBREW_PREFIX/"remote_repo" }
 
     before { remote_repo.mkpath }

Library/Homebrew/test/formula_spec.rb

@@ -521,10 +521,10 @@ describe Formula do
     end
 
     expect(f.homepage).to eq("https://brew.sh")
-    expect(f.version).to eq(Version.create("0.1"))
+    expect(f.version).to eq(Version.new("0.1"))
     expect(f).to be_stable
-    expect(f.stable.version).to eq(Version.create("0.1"))
+    expect(f.stable.version).to eq(Version.new("0.1"))
-    expect(f.head.version).to eq(Version.create("HEAD"))
+    expect(f.head.version).to eq(Version.new("HEAD"))
   end
 
   specify "#active_spec=" do
@@ -624,7 +624,7 @@ describe Formula do
 
     f.update_head_version
 
-    expect(f.head.version).to eq(Version.create("HEAD-5658946"))
+    expect(f.head.version).to eq(Version.new("HEAD-5658946"))
   end
 
   specify "#desc" do

Library/Homebrew/test/macos_version_spec.rb

@@ -27,10 +27,10 @@ describe MacOSVersion do
   end
 
   specify "comparison with Version" do
-    expect(version).to be > Version.create("10.3")
+    expect(version).to be > Version.new("10.3")
-    expect(version).to be == Version.create("10.14")
+    expect(version).to be == Version.new("10.14")
-    expect(version).to be === Version.create("10.14") # rubocop:disable Style/CaseEquality
+    expect(version).to be === Version.new("10.14") # rubocop:disable Style/CaseEquality
-    expect(version).to be < Version.create("10.15")
+    expect(version).to be < Version.new("10.15")
   end
 
   describe "after Big Sur" do

Library/Homebrew/test/pkg_version_spec.rb

@@ -5,12 +5,12 @@ require "pkg_version"
 describe PkgVersion do
   describe "::parse" do
     it "parses versions from a string" do
-      expect(described_class.parse("1.0_1")).to eq(described_class.new(Version.create("1.0"), 1))
+      expect(described_class.parse("1.0_1")).to eq(described_class.new(Version.new("1.0"), 1))
-      expect(described_class.parse("1.0_1")).to eq(described_class.new(Version.create("1.0"), 1))
+      expect(described_class.parse("1.0_1")).to eq(described_class.new(Version.new("1.0"), 1))
-      expect(described_class.parse("1.0")).to eq(described_class.new(Version.create("1.0"), 0))
+      expect(described_class.parse("1.0")).to eq(described_class.new(Version.new("1.0"), 0))
-      expect(described_class.parse("1.0_0")).to eq(described_class.new(Version.create("1.0"), 0))
+      expect(described_class.parse("1.0_0")).to eq(described_class.new(Version.new("1.0"), 0))
-      expect(described_class.parse("2.1.4_0")).to eq(described_class.new(Version.create("2.1.4"), 0))
+      expect(described_class.parse("2.1.4_0")).to eq(described_class.new(Version.new("2.1.4"), 0))
-      expect(described_class.parse("1.0.1e_1")).to eq(described_class.new(Version.create("1.0.1e"), 1))
+      expect(described_class.parse("1.0.1e_1")).to eq(described_class.new(Version.new("1.0.1e"), 1))
     end
   end
 
@@ -32,13 +32,13 @@ describe PkgVersion do
 
     it "raises an error if the other side isn't of the same class" do
       expect do
-        described_class.new(Version.create("1.0"), 0) > Object.new
+        described_class.new(Version.new("1.0"), 0) > Object.new
       end.to raise_error(ArgumentError)
     end
 
     it "is not compatible with Version" do
       expect do
-        described_class.new(Version.create("1.0"), 0) > Version.create("1.0")
+        described_class.new(Version.new("1.0"), 0) > Version.new("1.0")
       end.to raise_error(ArgumentError)
     end
   end
@@ -55,33 +55,33 @@ describe PkgVersion do
 
   describe "#<=>" do
     it "returns nil if the comparison fails" do
-      expect(described_class.new(Version.create("1.0"), 0) <=> Object.new).to be_nil
+      expect(described_class.new(Version.new("1.0"), 0) <=> Object.new).to be_nil
-      expect(Object.new <=> described_class.new(Version.create("1.0"), 0)).to be_nil
+      expect(Object.new <=> described_class.new(Version.new("1.0"), 0)).to be_nil
-      expect(Object.new <=> described_class.new(Version.create("1.0"), 0)).to be_nil
+      expect(Object.new <=> described_class.new(Version.new("1.0"), 0)).to be_nil
-      expect(described_class.new(Version.create("1.0"), 0) <=> nil).to be_nil
+      expect(described_class.new(Version.new("1.0"), 0) <=> nil).to be_nil
       # This one used to fail due to dereferencing a null `self`
-      expect(described_class.new(nil, 0) <=> described_class.new(Version.create("1.0"), 0)).to be_nil
+      expect(described_class.new(nil, 0) <=> described_class.new(Version.new("1.0"), 0)).to be_nil
     end
   end
 
   describe "#to_s" do
     it "returns a string of the form 'version_revision'" do
-      expect(described_class.new(Version.create("1.0"), 0).to_s).to eq("1.0")
+      expect(described_class.new(Version.new("1.0"), 0).to_s).to eq("1.0")
-      expect(described_class.new(Version.create("1.0"), 1).to_s).to eq("1.0_1")
+      expect(described_class.new(Version.new("1.0"), 1).to_s).to eq("1.0_1")
-      expect(described_class.new(Version.create("1.0"), 0).to_s).to eq("1.0")
+      expect(described_class.new(Version.new("1.0"), 0).to_s).to eq("1.0")
-      expect(described_class.new(Version.create("1.0"), 0).to_s).to eq("1.0")
+      expect(described_class.new(Version.new("1.0"), 0).to_s).to eq("1.0")
-      expect(described_class.new(Version.create("HEAD"), 1).to_s).to eq("HEAD_1")
+      expect(described_class.new(Version.new("HEAD"), 1).to_s).to eq("HEAD_1")
-      expect(described_class.new(Version.create("HEAD-ffffff"), 1).to_s).to eq("HEAD-ffffff_1")
+      expect(described_class.new(Version.new("HEAD-ffffff"), 1).to_s).to eq("HEAD-ffffff_1")
     end
   end
 
   describe "#hash" do
-    let(:version_one_revision_one) { described_class.new(Version.create("1.0"), 1) }
+    let(:version_one_revision_one) { described_class.new(Version.new("1.0"), 1) }
-    let(:version_one_dot_one_revision_one) { described_class.new(Version.create("1.1"), 1) }
+    let(:version_one_dot_one_revision_one) { described_class.new(Version.new("1.1"), 1) }
-    let(:version_one_revision_zero) { described_class.new(Version.create("1.0"), 0) }
+    let(:version_one_revision_zero) { described_class.new(Version.new("1.0"), 0) }
 
     it "returns a hash based on the version and revision" do
-      expect(version_one_revision_one.hash).to eq(described_class.new(Version.create("1.0"), 1).hash)
+      expect(version_one_revision_one.hash).to eq(described_class.new(Version.new("1.0"), 1).hash)
       expect(version_one_revision_one.hash).not_to eq(version_one_dot_one_revision_one.hash)
       expect(version_one_revision_one.hash).not_to eq(version_one_revision_zero.hash)
     end
@@ -89,7 +89,7 @@ describe PkgVersion do
 
   describe "#version" do
     it "returns package version" do
-      expect(described_class.parse("1.2.3_4").version).to be == Version.create("1.2.3")
+      expect(described_class.parse("1.2.3_4").version).to be == Version.new("1.2.3")
     end
   end
 
@@ -119,13 +119,13 @@ describe PkgVersion do
 
   describe "#major_minor" do
     it "returns major.minor version" do
-      expect(described_class.parse("1.2.3_4").major_minor).to be == Version.create("1.2")
+      expect(described_class.parse("1.2.3_4").major_minor).to be == Version.new("1.2")
     end
   end
 
   describe "#major_minor_patch" do
     it "returns major.minor.patch version" do
-      expect(described_class.parse("1.2.3_4").major_minor_patch).to be == Version.create("1.2.3")
+      expect(described_class.parse("1.2.3_4").major_minor_patch).to be == Version.new("1.2.3")
     end
   end
 end

Library/Homebrew/test/software_spec/head_spec.rb

@@ -6,7 +6,7 @@ describe HeadSoftwareSpec do
   subject(:head_spec) { described_class.new }
 
   specify "#version" do
-    expect(head_spec.version).to eq(Version.create("HEAD"))
+    expect(head_spec.version).to eq(Version.new("HEAD"))
   end
 
   specify "#verify_download_integrity" do

Library/Homebrew/utils/git.rb

@@ -146,7 +146,7 @@ module Utils
     def self.supports_partial_clone_sparse_checkout?
       # There is some support for partial clones prior to 2.20, but we avoid using it
       # due to performance issues
-      Version.create(version) >= Version.create("2.20.0")
+      Version.new(version) >= Version.new("2.20.0")
     end
   end
 end

Library/Homebrew/utils/github/api.rb

@@ -159,10 +159,8 @@ module GitHub
       github_password
     end
 
-    # odeprecated: Not really deprecated; change the order to prefer `github_cli_token` over
-    # `keychain_username_password` during the next major/minor release.
     def self.credentials
-      @credentials ||= Homebrew::EnvConfig.github_api_token || keychain_username_password || github_cli_token
+      @credentials ||= Homebrew::EnvConfig.github_api_token || github_cli_token || keychain_username_password
     end
 
     sig { returns(Symbol) }

Library/Homebrew/utils/svn.rb

@@ -40,7 +40,7 @@ module Utils
       def invalid_cert_flags
         opoo "Ignoring Subversion certificate errors!"
         args = ["--non-interactive", "--trust-server-cert"]
-        if Version.create(version || "-1") >= Version.create("1.9")
+        if Version.new(version || "-1") >= Version.new("1.9")
           args << "--trust-server-cert-failures=expired,not-yet-valid"
         end
         args

Library/Homebrew/version.rb

@@ -343,7 +343,7 @@ class Version
 
   sig { params(val: String).returns(Version) }
   def self.create(val)
-    # odeprecate "Version.create", "Version.new"
+    odeprecated "Version.create", "Version.new"
     new(val)
   end
 

completions/bash/brew

@@ -126,7 +126,6 @@ _brew___cache() {
       __brewcomp "
       --HEAD
       --arch
-      --bottle-tag
       --build-from-source
       --cask
       --debug

completions/fish/brew.fish

@@ -193,7 +193,6 @@ end
 __fish_brew_complete_cmd '--cache' 'Display Homebrew\'s download cache'
 __fish_brew_complete_arg '--cache' -l HEAD -d 'Show the cache file used when building from HEAD'
 __fish_brew_complete_arg '--cache' -l arch -d 'Show cache file for the given CPU architecture.(Pass `all` to show cache files for all architectures.)'
-__fish_brew_complete_arg '--cache' -l bottle-tag -d 'Show the cache file used when pouring a bottle for the given tag'
 __fish_brew_complete_arg '--cache' -l build-from-source -d 'Show the cache file used when building from source'
 __fish_brew_complete_arg '--cache' -l cask -d 'Only show cache files for casks'
 __fish_brew_complete_arg '--cache' -l debug -d 'Display any debugging information'

completions/zsh/_brew

@@ -264,7 +264,6 @@ _brew___cache() {
   _arguments \
     '(--build-from-source --force-bottle --bottle-tag --cask)--HEAD[Show the cache file used when building from HEAD]' \
     '(--bottle-tag)--arch[Show cache file for the given CPU architecture.(Pass `all` to show cache files for all architectures.)]' \
-    '(--build-from-source --force-bottle --HEAD --cask --os --arch)--bottle-tag[Show the cache file used when pouring a bottle for the given tag]' \
     '(--force-bottle --bottle-tag --HEAD --cask)--build-from-source[Show the cache file used when building from source]' \
     '--debug[Display any debugging information]' \
     '(--build-from-source --bottle-tag --HEAD --cask)--force-bottle[Show the cache file used when pouring a bottle]' \

docs/Manpage.md

@@ -856,8 +856,6 @@ If *`formula`* is provided, display the file or directory used to cache *`formul
   Show the cache file used when building from source.
 * `--force-bottle`:
   Show the cache file used when pouring a bottle.
-* `--bottle-tag`:
-  Show the cache file used when pouring a bottle for the given tag.
 * `--HEAD`:
   Show the cache file used when building from HEAD.
 * `--formula`:

manpages/brew.1

@@ -1211,10 +1211,6 @@ Show the cache file used when building from source\.
 Show the cache file used when pouring a bottle\.
 .
 .TP
-\fB\-\-bottle\-tag\fR
-Show the cache file used when pouring a bottle for the given tag\.
-.
-.TP
 \fB\-\-HEAD\fR
 Show the cache file used when building from HEAD\.
 .