From 7d9758a05ecf8cef93ba919568579cd0bee58c82 Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Mon, 30 Nov 2020 16:27:49 +0100 Subject: [PATCH] Fix RuboCop offenses. --- Library/Homebrew/extend/os/mac/hardware/cpu.rb | 2 +- Library/Homebrew/formula.rb | 2 +- Library/Homebrew/formula_installer.rb | 2 +- Library/Homebrew/rubocops/livecheck.rb | 2 +- Library/Homebrew/test/exceptions_spec.rb | 1 + 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Library/Homebrew/extend/os/mac/hardware/cpu.rb b/Library/Homebrew/extend/os/mac/hardware/cpu.rb index ad84a72420..ca9cded68d 100644 --- a/Library/Homebrew/extend/os/mac/hardware/cpu.rb +++ b/Library/Homebrew/extend/os/mac/hardware/cpu.rb @@ -77,7 +77,7 @@ module Hardware "machdep.cpu.features", "machdep.cpu.extfeatures", "machdep.cpu.leaf7_features", - ).split(" ").map { |s| s.downcase.to_sym } + ).split.map { |s| s.downcase.to_sym } end def sse4? diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb index 1cbadd4093..2ff5f3a619 100644 --- a/Library/Homebrew/formula.rb +++ b/Library/Homebrew/formula.rb @@ -2010,7 +2010,7 @@ class Formula @exec_count += 1 logfn = format("#{logs}/#{active_log_prefix}%02d.%s", exec_count: @exec_count, - cmd_base: File.basename(cmd).split(" ").first) + cmd_base: File.basename(cmd).split.first) logs.mkpath File.open(logfn, "w") do |log| diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index be714073e8..2f9667d99c 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -1217,7 +1217,7 @@ class FormulaInstaller pattern = /#{s.to_s.tr("_", " ")}/i forbidden_licenses.sub!(pattern, s.to_s) end - forbidden_licenses = forbidden_licenses.split(" ").to_h do |license| + forbidden_licenses = forbidden_licenses.split.to_h do |license| [license, SPDX.license_version_info(license)] end diff --git a/Library/Homebrew/rubocops/livecheck.rb b/Library/Homebrew/rubocops/livecheck.rb index f7e3bc55c4..748978298d 100644 --- a/Library/Homebrew/rubocops/livecheck.rb +++ b/Library/Homebrew/rubocops/livecheck.rb @@ -146,7 +146,7 @@ module RuboCop def autocorrect(node) lambda do |corrector| - pattern = node.source.split(" ")[1..].join + pattern = node.source.split[1..].join corrector.replace(node.source_range, "regex(#{pattern})") end end diff --git a/Library/Homebrew/test/exceptions_spec.rb b/Library/Homebrew/test/exceptions_spec.rb index fee12d3fbb..aaf8b54f08 100644 --- a/Library/Homebrew/test/exceptions_spec.rb +++ b/Library/Homebrew/test/exceptions_spec.rb @@ -81,6 +81,7 @@ describe FormulaClassUnavailableError do let(:mod) do Module.new do class Bar < Requirement; end + class Baz < Formula; end end end