admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Deprecate tap pinning

Browse Source 
Tap pinning is not used by Homebrew or the Homebrew maintainers so issues relating to pinned taps (#5418, #5796) don’t get fixed. Tap pinning does not work consistently or reliably and is conceptually confusing to encourage users to use fully-scoped user/tap/formula naming or avoid shadowing core tap formulae' names instead.
This commit is contained in:
Mike McQuaid 2019-03-30 10:17:34 +00:00
parent d12e39633c
commit 7d26a61cc8
No known key found for this signature in database
GPG Key ID: 48A898132FD8EE70
5 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/cmd/tap-pin.rb
View File

@ -12,10 +12,14 @@ module Homebrew
by the user. See also `tap-unpin`. by the user. See also `tap-unpin`.
EOS EOS
switch :debug switch :debug
hide_from_man_page!
end end
end end
def tap_pin def tap_pin
odeprecated "brew tap-pin user/tap",
"fully-scoped user/tap/formula naming"
tap_pin_args.parse tap_pin_args.parse
ARGV.named.each do |name| ARGV.named.each do |name|

4
Library/Homebrew/cmd/tap-unpin.rb
View File

@ -11,10 +11,14 @@ module Homebrew
Unpin <tap> so its formulae are no longer prioritised. See also `tap-pin`. Unpin <tap> so its formulae are no longer prioritised. See also `tap-pin`.
EOS EOS
switch :debug switch :debug
hide_from_man_page!
end end
end end
def tap_unpin def tap_unpin
odeprecated "brew tap-pin user/tap",
"fully-scoped user/tap/formula naming"
tap_unpin_args.parse tap_unpin_args.parse
ARGV.named.each do |name| ARGV.named.each do |name|

4
Library/Homebrew/formulary.rb
View File

@ -460,9 +460,13 @@ module Formulary
if possible_pinned_tap_formulae.size == 1 if possible_pinned_tap_formulae.size == 1
selected_formula = factory(possible_pinned_tap_formulae.first, spec) selected_formula = factory(possible_pinned_tap_formulae.first, spec)
if core_path(ref).file? if core_path(ref).file?
odeprecated "brew tap-pin user/tap",
"fully-scoped user/tap/formula naming"
opoo <<~EOS opoo <<~EOS
#{ref} is provided by core, but is now shadowed by #{selected_formula.full_name}. #{ref} is provided by core, but is now shadowed by #{selected_formula.full_name}.
This behaviour is deprecated and will be removed in Homebrew 2.2.0.
To refer to the core formula, use Homebrew/core/#{ref} instead. To refer to the core formula, use Homebrew/core/#{ref} instead.
To refer to the tap formula, use #{selected_formula.full_name} instead.
EOS EOS
end end
selected_formula selected_formula

9
docs/Manpage.md
View File

@ -488,15 +488,6 @@ summary of all installed taps if no *`tap`* are passed.
* `--json`: * `--json`:
Print a JSON representation of *`taps`*. Currently the default and only accepted value for *`version`* is `v1`. See the docs for examples of using the JSON output: <https://docs.brew.sh/Querying-Brew> Print a JSON representation of *`taps`*. Currently the default and only accepted value for *`version`* is `v1`. See the docs for examples of using the JSON output: <https://docs.brew.sh/Querying-Brew>
### `tap-pin` *`tap`*
Pin *`tap`*, prioritising its formulae over core when formula names are supplied
by the user. See also `tap-unpin`.
### `tap-unpin` *`tap`*
Unpin *`tap`* so its formulae are no longer prioritised. See also `tap-pin`.
### `uninstall`, `rm`, `remove` [*`options`*] *`formula`* ### `uninstall`, `rm`, `remove` [*`options`*] *`formula`*
Uninstall *`formula`*. Uninstall *`formula`*.

6
manpages/brew.1
View File

@ -612,12 +612,6 @@ Display information on all installed taps\.
\fB\-\-json\fR \fB\-\-json\fR
Print a JSON representation of \fItaps\fR\. Currently the default and only accepted value for \fIversion\fR is \fBv1\fR\. See the docs for examples of using the JSON output: \fIhttps://docs\.brew\.sh/Querying\-Brew\fR Print a JSON representation of \fItaps\fR\. Currently the default and only accepted value for \fIversion\fR is \fBv1\fR\. See the docs for examples of using the JSON output: \fIhttps://docs\.brew\.sh/Querying\-Brew\fR
. .
.SS "\fBtap\-pin\fR \fItap\fR"
Pin \fItap\fR, prioritising its formulae over core when formula names are supplied by the user\. See also \fBtap\-unpin\fR\.
.
.SS "\fBtap\-unpin\fR \fItap\fR"
Unpin \fItap\fR so its formulae are no longer prioritised\. See also \fBtap\-pin\fR\.
.
.SS "\fBuninstall\fR, \fBrm\fR, \fBremove\fR [\fIoptions\fR] \fIformula\fR" .SS "\fBuninstall\fR, \fBrm\fR, \fBremove\fR [\fIoptions\fR] \fIformula\fR"
Uninstall \fIformula\fR\. Uninstall \fIformula\fR\.
. .