Convert update report to use composition
This commit is contained in:
parent
346fa5098f
commit
7cd31377a4
@ -31,7 +31,7 @@ module Homebrew
|
|||||||
ensure
|
ensure
|
||||||
link_tap_formula(tapped_formulae)
|
link_tap_formula(tapped_formulae)
|
||||||
end
|
end
|
||||||
report.merge!(master_updater.report)
|
report.update(master_updater.report)
|
||||||
|
|
||||||
# rename Taps directories
|
# rename Taps directories
|
||||||
# this procedure will be removed in the future if it seems unnecessasry
|
# this procedure will be removed in the future if it seems unnecessasry
|
||||||
@ -46,7 +46,7 @@ module Homebrew
|
|||||||
rescue
|
rescue
|
||||||
onoe "Failed to update tap: #{user.basename}/#{repo.basename.sub("homebrew-", "")}"
|
onoe "Failed to update tap: #{user.basename}/#{repo.basename.sub("homebrew-", "")}"
|
||||||
else
|
else
|
||||||
report.merge!(updater.report) do |key, oldval, newval|
|
report.update(updater.report) do |key, oldval, newval|
|
||||||
oldval.concat(newval)
|
oldval.concat(newval)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
@ -207,7 +207,22 @@ class Updater
|
|||||||
end
|
end
|
||||||
|
|
||||||
|
|
||||||
class Report < Hash
|
class Report
|
||||||
|
def initialize
|
||||||
|
@hash = {}
|
||||||
|
end
|
||||||
|
|
||||||
|
def fetch(*args, &block)
|
||||||
|
@hash.fetch(*args, &block)
|
||||||
|
end
|
||||||
|
|
||||||
|
def update(*args, &block)
|
||||||
|
@hash.update(*args, &block)
|
||||||
|
end
|
||||||
|
|
||||||
|
def empty?
|
||||||
|
@hash.empty?
|
||||||
|
end
|
||||||
|
|
||||||
def dump
|
def dump
|
||||||
# Key Legend: Added (A), Copied (C), Deleted (D), Modified (M), Renamed (R)
|
# Key Legend: Added (A), Copied (C), Deleted (D), Modified (M), Renamed (R)
|
||||||
@ -216,8 +231,6 @@ class Report < Hash
|
|||||||
dump_formula_report :M, "Updated Formulae"
|
dump_formula_report :M, "Updated Formulae"
|
||||||
dump_formula_report :D, "Deleted Formulae"
|
dump_formula_report :D, "Deleted Formulae"
|
||||||
dump_formula_report :R, "Renamed Formulae"
|
dump_formula_report :R, "Renamed Formulae"
|
||||||
# dump_new_commands
|
|
||||||
# dump_deleted_commands
|
|
||||||
end
|
end
|
||||||
|
|
||||||
def tapped_formula_for key
|
def tapped_formula_for key
|
||||||
@ -268,5 +281,4 @@ class Report < Hash
|
|||||||
puts_columns formula.uniq
|
puts_columns formula.uniq
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
end
|
end
|
||||||
|
@ -54,7 +54,7 @@ class UpdaterTests < Homebrew::TestCase
|
|||||||
@updater.in_repo_expect("git rev-parse -q --verify HEAD", "3456cdef")
|
@updater.in_repo_expect("git rev-parse -q --verify HEAD", "3456cdef")
|
||||||
@updater.in_repo_expect("git diff-tree -r --raw -M85% 1234abcd 3456cdef", diff_output)
|
@updater.in_repo_expect("git diff-tree -r --raw -M85% 1234abcd 3456cdef", diff_output)
|
||||||
@updater.pull!
|
@updater.pull!
|
||||||
@report.merge!(@updater.report)
|
@report.update(@updater.report)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user