From 7c7ddd82fe8cf11880a60c83304f0558167cc6c8 Mon Sep 17 00:00:00 2001 From: Patrick Linnane Date: Mon, 8 May 2023 12:16:11 -0700 Subject: [PATCH] Revert "Merge pull request #15377 from carlocab/sorbet-runtime-take2" This reverts commit cca98d5637d847548791b5afb16a5c609de2cb58, reversing changes made to c0f8068573bbf886fdc78d3f9daca54d53e7e49e. --- Library/Homebrew/brew.sh | 24 ------------------------ Library/Homebrew/env_config.rb | 3 +-- docs/Manpage.md | 2 +- manpages/brew.1 | 2 +- 4 files changed, 3 insertions(+), 28 deletions(-) diff --git a/Library/Homebrew/brew.sh b/Library/Homebrew/brew.sh index 49692aa7e4..dd7aec3392 100644 --- a/Library/Homebrew/brew.sh +++ b/Library/Homebrew/brew.sh @@ -884,30 +884,6 @@ then fi fi -if [[ -n "${HOMEBREW_DEVELOPER}" || -n "${HOMEBREW_DEVELOPER_COMMAND}" ]] -then - # Always run with Sorbet for Homebrew developers or Homebrew developer commands. - export HOMEBREW_SORBET_RUNTIME="1" -fi - -# NO_SORBET_RUNTIME_COMMANDS are currently failing with Sorbet for homebrew/core. -# TODO: fix this and remove this if block. -if [[ -n "${HOMEBREW_SORBET_RUNTIME}" ]] -then - NO_SORBET_RUNTIME_COMMANDS=( - audit - determine-test-runners - readall - ) - - if check-array-membership "${HOMEBREW_COMMAND}" "${NO_SORBET_RUNTIME_COMMANDS[@]}" - then - unset HOMEBREW_SORBET_RUNTIME - fi - - unset NO_SORBET_RUNTIME_COMMANDS -fi - if [[ -n "${HOMEBREW_DEVELOPER_COMMAND}" && -z "${HOMEBREW_DEVELOPER}" ]] then if [[ -z "${HOMEBREW_DEV_CMD_RUN}" ]] diff --git a/Library/Homebrew/env_config.rb b/Library/Homebrew/env_config.rb index 70bfdabda4..5884ea4b05 100644 --- a/Library/Homebrew/env_config.rb +++ b/Library/Homebrew/env_config.rb @@ -357,8 +357,7 @@ module Homebrew boolean: true, }, HOMEBREW_SORBET_RUNTIME: { - description: "If set, enable runtime typechecking using Sorbet. " \ - "Set by default for HOMEBREW_DEVELOPER or when running developer commands.", + description: "If set, enable runtime typechecking using Sorbet.", boolean: true, }, HOMEBREW_SSH_CONFIG_PATH: { diff --git a/docs/Manpage.md b/docs/Manpage.md index e0ae3b7c60..619a65e2b0 100644 --- a/docs/Manpage.md +++ b/docs/Manpage.md @@ -2277,7 +2277,7 @@ example, run `export HOMEBREW_NO_INSECURE_REDIRECT=1` rather than just
If set along with `HOMEBREW_DEVELOPER`, do not use bottles from older versions of macOS. This is useful in development on new macOS versions. - `HOMEBREW_SORBET_RUNTIME` -
If set, enable runtime typechecking using Sorbet. Set by default for HOMEBREW_DEVELOPER or when running developer commands. +
If set, enable runtime typechecking using Sorbet. - `HOMEBREW_SSH_CONFIG_PATH`
If set, Homebrew will use the given config file instead of `~/.ssh/config` when fetching `git` repos over `ssh`. diff --git a/manpages/brew.1 b/manpages/brew.1 index 3a02e79a14..b830a7d5a4 100644 --- a/manpages/brew.1 +++ b/manpages/brew.1 @@ -3357,7 +3357,7 @@ If set along with \fBHOMEBREW_DEVELOPER\fR, do not use bottles from older versio \fBHOMEBREW_SORBET_RUNTIME\fR . .br -If set, enable runtime typechecking using Sorbet\. Set by default for HOMEBREW_DEVELOPER or when running developer commands\. +If set, enable runtime typechecking using Sorbet\. . .TP \fBHOMEBREW_SSH_CONFIG_PATH\fR