diff --git a/Library/Homebrew/linkage_checker.rb b/Library/Homebrew/linkage_checker.rb index c3d2bd9fe1..9af36adb0e 100644 --- a/Library/Homebrew/linkage_checker.rb +++ b/Library/Homebrew/linkage_checker.rb @@ -32,7 +32,6 @@ class LinkageChecker @unnecessary_deps = [] @unwanted_system_dylibs = [] @version_conflict_deps = [] - @broken_variable_dylibs = [] check_dylibs(rebuild_cache: rebuild_cache) end @@ -47,7 +46,6 @@ class LinkageChecker display_items "Undeclared dependencies with linkage", @undeclared_deps display_items "Dependencies with no linkage", @unnecessary_deps display_items "Unwanted system libraries", @unwanted_system_dylibs - display_items "Libraries with broken variable references", @broken_variable_dylibs end def display_reverse_output @@ -70,12 +68,11 @@ class LinkageChecker display_items "Broken dependencies", @broken_deps, puts_output: puts_output display_items "Unwanted system libraries", @unwanted_system_dylibs, puts_output: puts_output display_items "Conflicting libraries", @version_conflict_deps, puts_output: puts_output - display_items "Libraries with broken variable references", @broken_variable_dylibs, puts_output: puts_output end sig { returns(T::Boolean) } def broken_library_linkage? - issues = [@broken_deps, @unwanted_system_dylibs, @version_conflict_deps, @broken_variable_dylibs] + issues = [@broken_deps, @unwanted_system_dylibs, @version_conflict_deps] [issues, unexpected_broken_dylibs, unexpected_present_dylibs].flatten.any?(&:present?) end @@ -151,7 +148,6 @@ class LinkageChecker end checked_dylibs = Set.new - dlopened_if_needed_files = Set.new keg_files_dylibs.each do |file, dylibs| dylibs.each do |dylib| @@ -163,15 +159,6 @@ class LinkageChecker if dylib.start_with? "@" @variable_dylibs << dylib - - if dlopened_if_needed_files.add?(file) - file = Pathname.new(file) - next if file.binary_executable? - next if dylib_found_via_dlopen(file.dylib_id) - - @broken_variable_dylibs << file.dylib_id - end - next end