diff --git a/Library/Homebrew/rubocops/components_order.rb b/Library/Homebrew/rubocops/components_order.rb index f76351fc0e..7f6613799c 100644 --- a/Library/Homebrew/rubocops/components_order.rb +++ b/Library/Homebrew/rubocops/components_order.rb @@ -38,6 +38,8 @@ module RuboCop [{ name: :keg_only, type: :method_call }], [{ name: :option, type: :method_call }], [{ name: :deprecated_option, type: :method_call }], + [{ name: :disable!, type: :method_call }], + [{ name: :deprecate!, type: :method_call }], [{ name: :depends_on, type: :method_call }], [{ name: :uses_from_macos, type: :method_call }], [{ name: :on_macos, type: :block_call }], diff --git a/Library/Homebrew/test/rubocops/components_order_spec.rb b/Library/Homebrew/test/rubocops/components_order_spec.rb index 098e782546..8aa6bfc867 100644 --- a/Library/Homebrew/test/rubocops/components_order_spec.rb +++ b/Library/Homebrew/test/rubocops/components_order_spec.rb @@ -225,6 +225,31 @@ describe RuboCop::Cop::FormulaAudit::ComponentsOrder do corrected_source = autocorrect_source(source) expect(corrected_source).to eq(correct_source) end + + it "When `depends_on` precedes `deprecate!`" do + source = <<~RUBY + class Foo < Formula + url "https://brew.sh/foo-1.0.tgz" + + depends_on "openssl" + + deprecate! because: "has been replaced by bar" + end + RUBY + + correct_source = <<~RUBY + class Foo < Formula + url "https://brew.sh/foo-1.0.tgz" + + deprecate! because: "has been replaced by bar" + + depends_on "openssl" + end + RUBY + + corrected_source = autocorrect_source(source) + expect(corrected_source).to eq(correct_source) + end end context "no on_os_block" do