utils: send output to stderr by default for ensure_formula_installed!

This commit is contained in:
XuehaiPan 2021-11-23 23:09:42 +08:00
parent 3376479e95
commit 7baaebe544

View File

@ -456,8 +456,8 @@ module Kernel
# Ensure the given formula is installed
# This is useful for installing a utility formula (e.g. `shellcheck` for `brew style`)
def ensure_formula_installed!(formula_or_name, reason = "", latest: false, linked: false,
output_to_stderr: false, quiet: false)
def ensure_formula_installed!(formula_or_name, reason = "", latest: false,
output_to_stderr: true, quiet: false)
if output_to_stderr || quiet
file = if quiet
File::NULL
@ -466,7 +466,7 @@ module Kernel
end
# Call this method itself with redirected stdout
redirect_stdout(file) do
return ensure_formula_installed!(formula_or_name, reason, latest: latest, linked: linked)
return ensure_formula_installed!(formula_or_name, reason, latest: latest, output_to_stderr: false)
end
end
@ -490,8 +490,6 @@ module Kernel
safe_system HOMEBREW_BREW_FILE, "upgrade", "--formula", formula.full_name
end
safe_system HOMEBREW_BREW_FILE, "link", formula.full_name if linked && !formula.linked?
formula
end