From 3d391d6427b9dcba92114ad1271117028d5d766d Mon Sep 17 00:00:00 2001 From: lexicol <67622970+lexicol@users.noreply.github.com> Date: Sat, 6 Mar 2021 13:13:58 -0800 Subject: [PATCH 1/2] dev-cmd/create: use std_configure_args --- Library/Homebrew/formula_creator.rb | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/Library/Homebrew/formula_creator.rb b/Library/Homebrew/formula_creator.rb index f9aa3f0c30..2a48c17325 100644 --- a/Library/Homebrew/formula_creator.rb +++ b/Library/Homebrew/formula_creator.rb @@ -156,10 +156,7 @@ module Homebrew system "cmake", ".", *std_cmake_args <% elsif mode == :autotools %> # Remove unrecognized options if warned by configure - system "./configure", "--disable-debug", - "--disable-dependency-tracking", - "--disable-silent-rules", - "--prefix=\#{prefix}" + system "./configure", *std_configure_args, "--disable-silent-rules" <% elsif mode == :crystal %> system "shards", "build", "--release" bin.install "bin/#{name}" @@ -206,10 +203,7 @@ module Homebrew system "cargo", "install", *std_cargo_args <% else %> # Remove unrecognized options if warned by configure - system "./configure", "--disable-debug", - "--disable-dependency-tracking", - "--disable-silent-rules", - "--prefix=\#{prefix}" + system "./configure", *std_configure_args, "--disable-silent-rules" # system "cmake", ".", *std_cmake_args <% end %> <% if mode == :autotools || mode == :cmake %> From 9cc93154a0a29ae517f9829df2fd261b419782c9 Mon Sep 17 00:00:00 2001 From: lexicol <67622970+lexicol@users.noreply.github.com> Date: Mon, 8 Mar 2021 12:57:35 -0800 Subject: [PATCH 2/2] dev-cmd/create: add link to std_configure_args --- Library/Homebrew/formula_creator.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Library/Homebrew/formula_creator.rb b/Library/Homebrew/formula_creator.rb index 2a48c17325..db78bdce52 100644 --- a/Library/Homebrew/formula_creator.rb +++ b/Library/Homebrew/formula_creator.rb @@ -156,6 +156,7 @@ module Homebrew system "cmake", ".", *std_cmake_args <% elsif mode == :autotools %> # Remove unrecognized options if warned by configure + # https://rubydoc.brew.sh/Formula.html#std_configure_args-instance_method system "./configure", *std_configure_args, "--disable-silent-rules" <% elsif mode == :crystal %> system "shards", "build", "--release" @@ -203,6 +204,7 @@ module Homebrew system "cargo", "install", *std_cargo_args <% else %> # Remove unrecognized options if warned by configure + # https://rubydoc.brew.sh/Formula.html#std_configure_args-instance_method system "./configure", *std_configure_args, "--disable-silent-rules" # system "cmake", ".", *std_cmake_args <% end %>