admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: Add check_repository_references

Browse Source 
Ensure that any references to HOMEBREW_REPOSITORY
are within HOMEBREW_LIBRARY.
This commit is contained in:
Shaun Jackman 2020-12-11 10:53:15 -08:00
parent 65b9e1231d
commit 7b408dffc9
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
Library/Homebrew/formula_cellar_checks.rb
View File

@ -7,6 +7,8 @@ require "utils/shell"
# #
# @api private # @api private
module FormulaCellarChecks module FormulaCellarChecks
REPOSITORY_AND_NOT_LIBRARY_REGEX = %r{#{HOMEBREW_REPOSITORY}(?!/Library/)}.freeze
def check_env_path(bin) def check_env_path(bin)
# warn the user if stuff was installed outside of their PATH # warn the user if stuff was installed outside of their PATH
return unless bin.directory? return unless bin.directory?
@ -207,6 +209,25 @@ module FormulaCellarChecks
EOS EOS
end end
def check_repository_references(prefix)
return unless prefix.directory?
keg = Keg.new(prefix)
matches = []
keg.each_unique_file_matching(HOMEBREW_REPOSITORY) do |f|
matches << f.relative_path_from(keg.to_path) if f.read.match? REPOSITORY_AND_NOT_LIBRARY_REGEX
end
return if matches.empty?
<<~EOS
Files were found with references to the Homebrew repository directory
that are outside of the Library directory. The offending files are:
#{matches * "\n "}
EOS
end
def check_shim_references(prefix) def check_shim_references(prefix)
return unless prefix.directory? return unless prefix.directory?
@ -292,6 +313,7 @@ module FormulaCellarChecks
problem_if_output(check_elisp_dirname(formula.share, formula.name)) problem_if_output(check_elisp_dirname(formula.share, formula.name))
problem_if_output(check_elisp_root(formula.share, formula.name)) problem_if_output(check_elisp_root(formula.share, formula.name))
problem_if_output(check_python_packages(formula.lib, formula.deps)) problem_if_output(check_python_packages(formula.lib, formula.deps))
problem_if_output(check_repository_references(formula.prefix))
problem_if_output(check_shim_references(formula.prefix)) problem_if_output(check_shim_references(formula.prefix))
problem_if_output(check_plist(formula.prefix, formula.plist)) problem_if_output(check_plist(formula.prefix, formula.plist))
problem_if_output(check_python_symlinks(formula.name, formula.keg_only?)) problem_if_output(check_python_symlinks(formula.name, formula.keg_only?))