admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #12819 from rolandcrosby/rubocop-cargo-lib

Browse Source 
Formula: Allow `cargo build` when building libraries
This commit is contained in:
Mike McQuaid 2022-02-01 08:36:22 +00:00 committed by GitHub
commit 7a31b3bebf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/rubocops/text.rb
View File

@ -70,7 +70,9 @@ module RuboCop
problem "use \"dep\", \"ensure\", \"-vendor-only\"" problem "use \"dep\", \"ensure\", \"-vendor-only\""
end end
find_method_with_args(body_node, :system, "cargo", "build") do find_method_with_args(body_node, :system, "cargo", "build") do |m|
next if parameters_passed?(m, /--lib/)
problem "use \"cargo\", \"install\", *std_cargo_args" problem "use \"cargo\", \"install\", *std_cargo_args"
end end

13
Library/Homebrew/test/rubocops/text_spec.rb
View File

@ -205,6 +205,19 @@ describe RuboCop::Cop::FormulaAudit::Text do
RUBY RUBY
end end
it "doesn't reports an offense if `cargo build` is executed with --lib" do
expect_no_offenses(<<~RUBY)
class Foo < Formula
url "https://brew.sh/foo-1.0.tgz"
homepage "https://brew.sh"
def install
system "cargo", "build", "--lib"
end
end
RUBY
end
it "reports an offense if `make` calls are not separated" do it "reports an offense if `make` calls are not separated" do
expect_offense(<<~RUBY) expect_offense(<<~RUBY)
class Foo < Formula class Foo < Formula