Merge pull request #15692 from dtrodrigues/pypi_version

utils/pypi: don't overwrite name/extras/version from basic_metadata if already set
This commit is contained in:
Mike McQuaid 2023-07-18 17:15:57 +01:00 committed by GitHub
commit 79e67737a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -127,9 +127,9 @@ module PyPI
match = File.basename(@package_string).match(/^(.+)-([a-z\d.]+?)(?:.tar.gz|.zip)$/)
raise ArgumentError, "Package should be a valid PyPI URL" if match.blank?
@name = PyPI.normalize_python_package match[1]
@extras = []
@version = match[2]
@name ||= PyPI.normalize_python_package match[1]
@extras ||= []
@version ||= match[2]
elsif @is_url
ensure_formula_installed!("python")
@ -152,9 +152,9 @@ module PyPI
metadata = JSON.parse(pip_output)["install"].first["metadata"]
@name = PyPI.normalize_python_package metadata["name"]
@extras = []
@version = metadata["version"]
@name ||= PyPI.normalize_python_package metadata["name"]
@extras ||= []
@version ||= metadata["version"]
else
if @package_string.include? "=="
name, version = @package_string.split("==")
@ -170,9 +170,9 @@ module PyPI
extras = []
end
@name = PyPI.normalize_python_package name
@extras = extras
@version = version
@name ||= PyPI.normalize_python_package name
@extras ||= extras
@version ||= version
end
end
end