admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: check for gfotran in Formula#deps instead

Browse Source 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Jack Nagel 2012-03-01 19:56:09 -06:00
parent 7f39c999a6
commit 79d1c2396a
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Library/Homebrew/cmd/audit.rb
View File

@ -98,11 +98,6 @@ def audit_formula_text name, text
problems << " * Use spaces instead of tabs for indentation" problems << " * Use spaces instead of tabs for indentation"
end end
# Formula depends_on gfortran
if text =~ /^\s*depends_on\s*(\'|\")gfortran(\'|\").*/
problems << " * Use ENV.fortran during install instead of depends_on 'gfortran'"
end unless name == "gfortran" # Gfortran itself has this text in the caveats
# xcodebuild should specify SYMROOT # xcodebuild should specify SYMROOT
if text =~ /system\s+['"]xcodebuild/ and not text =~ /SYMROOT=/ if text =~ /system\s+['"]xcodebuild/ and not text =~ /SYMROOT=/
problems << " * xcodebuild should be passed an explicit \"SYMROOT\"" problems << " * xcodebuild should be passed an explicit \"SYMROOT\""
@ -287,6 +282,8 @@ def audit_formula_instance f
* Don't use #{d} as a dependency. We allow non-Homebrew * Don't use #{d} as a dependency. We allow non-Homebrew
#{d} installations. #{d} installations.
EOS EOS
when 'gfortran'
problems << " * Use ENV.fortran during install instead of depends_on 'gfortran'"
end end
end end